From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764313AbcINQHA (ORCPT ); Wed, 14 Sep 2016 12:07:00 -0400 Received: from mga07.intel.com ([134.134.136.100]:4407 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756501AbcINQG7 (ORCPT ); Wed, 14 Sep 2016 12:06:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,334,1470726000"; d="scan'208";a="8748621" Date: Wed, 14 Sep 2016 19:06:55 +0300 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: "jgunthorpe@obsidianresearch.com" , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 0/4] tpm/tpm_crb: implement power management. Message-ID: <20160914160652.GA12158@intel.com> References: <1473685461-6540-1-git-send-email-tomas.winkler@intel.com> <1473834369.21459.4.camel@intel.com> <20160914160602.GB11131@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160914160602.GB11131@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 07:06:02PM +0300, Jarkko Sakkinen wrote: > On Wed, Sep 14, 2016 at 06:28:03AM +0000, Winkler, Tomas wrote: > > On Mon, 2016-09-12 at 16:04 +0300, Tomas Winkler wrote: > > > Te overall platform ability to enter a low power state is also > > > conditioned on the ability of a tpm device to go to idle state. > > > This series should provide this feature. > > > > > > Unfortunately, there is a HW bug on Intel PTT devices on Skylake, > > > Kabylake, and Broxton devices, where certain registers lost retention > > > during TPM idle state. Hence this implementation takes this into > > > consideration and implement the feature based only on access to > > > registers that retain their state. This still conforms to the spec > > > and should be correct also on non Intle devices. > > > > > > V2: Utilize runtime_pm for driving tpm crb idle states. > > > V3. fix lower case corruption in the first patch > > > > > Jarkko, had you chance to test v3 series one on your side, is this okay > > to go? > > Opens for me are: > > - pm_runtime_put_sync() is still used > - callback names > - wait_for_tpm_stat I also tested v3 and it works for me. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v3 0/4] tpm/tpm_crb: implement power management. Date: Wed, 14 Sep 2016 19:06:55 +0300 Message-ID: <20160914160652.GA12158@intel.com> References: <1473685461-6540-1-git-send-email-tomas.winkler@intel.com> <1473834369.21459.4.camel@intel.com> <20160914160602.GB11131@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160914160602.GB11131-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Winkler, Tomas" Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Sep 14, 2016 at 07:06:02PM +0300, Jarkko Sakkinen wrote: > On Wed, Sep 14, 2016 at 06:28:03AM +0000, Winkler, Tomas wrote: > > On Mon, 2016-09-12 at 16:04 +0300, Tomas Winkler wrote: > > > Te overall platform ability to enter a low power state is also > > > conditioned on the ability of a tpm device to go to idle state. > > > This series should provide this feature. > > > > > > Unfortunately, there is a HW bug on Intel PTT devices on Skylake, > > > Kabylake, and Broxton devices, where certain registers lost retention > > > during TPM idle state. Hence this implementation takes this into > > > consideration and implement the feature based only on access to > > > registers that retain their state. This still conforms to the spec > > > and should be correct also on non Intle devices. > > > > > > V2: Utilize runtime_pm for driving tpm crb idle states. > > > V3. fix lower case corruption in the first patch > > > > > Jarkko, had you chance to test v3 series one on your side, is this okay > > to go? > > Opens for me are: > > - pm_runtime_put_sync() is still used > - callback names > - wait_for_tpm_stat I also tested v3 and it works for me. /Jarkko ------------------------------------------------------------------------------