From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761605AbcINRFK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 13:05:10 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:40541 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753427AbcINRFI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 13:05:08 -0400
Date: Wed, 14 Sep 2016 19:04:52 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: x86@kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: perf/x86: Use kmalloc_array() in merge_attr()
Message-ID: <20160914170452.GD5016@twins.programming.kicks-ass.net>
References: <daf81ea8-21bc-d5d0-11af-8957216ae323@users.sourceforge.net>
 <20160905075149.GQ10153@twins.programming.kicks-ass.net>
 <a465479e-59eb-b047-dbe6-f3686b4ecd31@users.sourceforge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a465479e-59eb-b047-dbe6-f3686b4ecd31@users.sourceforge.net>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2016 at 06:40:32PM +0200, SF Markus Elfring wrote:
> 
> Would you like to suggest any more constraints for this kind of
> software refactoring?

Yes, don't do it. If you're writing new code by all means, do whatever
you feel, but don't go changing code just because checkpatch.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Date: Wed, 14 Sep 2016 17:04:52 +0000
Subject: Re: perf/x86: Use kmalloc_array() in merge_attr()
Message-Id: <20160914170452.GD5016@twins.programming.kicks-ass.net>
List-Id: <kernel-janitors.vger.kernel.org>
References: <daf81ea8-21bc-d5d0-11af-8957216ae323@users.sourceforge.net>
 <20160905075149.GQ10153@twins.programming.kicks-ass.net>
 <a465479e-59eb-b047-dbe6-f3686b4ecd31@users.sourceforge.net>
In-Reply-To: <a465479e-59eb-b047-dbe6-f3686b4ecd31@users.sourceforge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: x86@kernel.org, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>

On Wed, Sep 14, 2016 at 06:40:32PM +0200, SF Markus Elfring wrote:
> 
> Would you like to suggest any more constraints for this kind of
> software refactoring?

Yes, don't do it. If you're writing new code by all means, do whatever
you feel, but don't go changing code just because checkpatch.