From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933350AbcINT0a (ORCPT ); Wed, 14 Sep 2016 15:26:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:46118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110AbcINT01 (ORCPT ); Wed, 14 Sep 2016 15:26:27 -0400 Date: Wed, 14 Sep 2016 14:26:21 -0500 From: Bjorn Helgaas To: Mika Westerberg Cc: Bjorn Helgaas , Mayurkumar Patel , Rajat Jain , MikaWesterberg@linux.intel.com, linux-pci@vger.kernel.org, Rafael J Wysocki , linux-kernel@vger.kernel.org, Keith Busch , Luis Antonio Tarazona-Duarte , Andy Shevchenko Subject: Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine Message-ID: <20160914192621.GA10559@localhost> References: <20160912210507.22258.63097.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20160914084117.GX1811@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160914084117.GX1811@lahna.fi.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 11:41:17AM +0300, Mika Westerberg wrote: > On Mon, Sep 12, 2016 at 04:08:47PM -0500, Bjorn Helgaas wrote: > > This is mostly Mayurkumar's work from [1] and [2]. I split [2] into two > > patches and reworked it to keep the enclosing loop around the pciehp ISR. > > > > The patches I added are trivial ones to clarify variable names, make dmesg > > messages consistent, and remove useless code. > > > > [1] 1471554479-42083-1-git-send-email-mayurkumar.patel@intel.com > > [2] 92EBB4272BF81E4089A7126EC1E7B28466598F35@IRSMSX101.ger.corp.intel.com > > > > --- > > > > Bjorn Helgaas (5): > > PCI: pciehp: Rename pcie_isr() locals for clarity > > PCI: pciehp: Return IRQ_NONE when we can't read interrupt status > > PCI: pciehp: Remove unnecessary guard > > PCI: pciehp: Clean up dmesg "Slot(%s)" messages > > PCI: pciehp: Remove useless pciehp_get_latch_status() calls > > > > Mayurkumar Patel (3): > > PCI: pciehp: Process all hotplug events before looking for new ones > > PCI: pciehp: Don't re-read Slot Status when queuing hotplug event > > PCI: pciehp: Don't re-read Slot Status when handling surprise event > > > > > > drivers/pci/hotplug/pciehp_ctrl.c | 83 ++++++++++++--------------------- > > drivers/pci/hotplug/pciehp_hpc.c | 94 ++++++++++++++++++++----------------- > > 2 files changed, 82 insertions(+), 95 deletions(-) > > I don't have any machines with native PCIe hotplug support enabled but > regardless the series looks good to me, > > Reviewed-by: Mika Westerberg Thanks a lot for taking the time to review it! I added your Reviewed-by. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:46118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110AbcINT01 (ORCPT ); Wed, 14 Sep 2016 15:26:27 -0400 Date: Wed, 14 Sep 2016 14:26:21 -0500 From: Bjorn Helgaas To: Mika Westerberg Cc: Bjorn Helgaas , Mayurkumar Patel , Rajat Jain , MikaWesterberg@linux.intel.com, linux-pci@vger.kernel.org, Rafael J Wysocki , linux-kernel@vger.kernel.org, Keith Busch , Luis Antonio Tarazona-Duarte , Andy Shevchenko Subject: Re: [PATCH v2 0/8] PCI: pciehp: Rework hotplug interrupt routine Message-ID: <20160914192621.GA10559@localhost> References: <20160912210507.22258.63097.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20160914084117.GX1811@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160914084117.GX1811@lahna.fi.intel.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Sep 14, 2016 at 11:41:17AM +0300, Mika Westerberg wrote: > On Mon, Sep 12, 2016 at 04:08:47PM -0500, Bjorn Helgaas wrote: > > This is mostly Mayurkumar's work from [1] and [2]. I split [2] into two > > patches and reworked it to keep the enclosing loop around the pciehp ISR. > > > > The patches I added are trivial ones to clarify variable names, make dmesg > > messages consistent, and remove useless code. > > > > [1] 1471554479-42083-1-git-send-email-mayurkumar.patel@intel.com > > [2] 92EBB4272BF81E4089A7126EC1E7B28466598F35@IRSMSX101.ger.corp.intel.com > > > > --- > > > > Bjorn Helgaas (5): > > PCI: pciehp: Rename pcie_isr() locals for clarity > > PCI: pciehp: Return IRQ_NONE when we can't read interrupt status > > PCI: pciehp: Remove unnecessary guard > > PCI: pciehp: Clean up dmesg "Slot(%s)" messages > > PCI: pciehp: Remove useless pciehp_get_latch_status() calls > > > > Mayurkumar Patel (3): > > PCI: pciehp: Process all hotplug events before looking for new ones > > PCI: pciehp: Don't re-read Slot Status when queuing hotplug event > > PCI: pciehp: Don't re-read Slot Status when handling surprise event > > > > > > drivers/pci/hotplug/pciehp_ctrl.c | 83 ++++++++++++--------------------- > > drivers/pci/hotplug/pciehp_hpc.c | 94 ++++++++++++++++++++----------------- > > 2 files changed, 82 insertions(+), 95 deletions(-) > > I don't have any machines with native PCIe hotplug support enabled but > regardless the series looks good to me, > > Reviewed-by: Mika Westerberg Thanks a lot for taking the time to review it! I added your Reviewed-by.