From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933375AbcINUwb (ORCPT ); Wed, 14 Sep 2016 16:52:31 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37423 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933163AbcINUw2 (ORCPT ); Wed, 14 Sep 2016 16:52:28 -0400 Date: Wed, 14 Sep 2016 22:52:23 +0200 From: Richard Cochran To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Mugunthan V N , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, WingMan Kwok Subject: Re: [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization Message-ID: <20160914205223.GF12195@netboy> References: <20160914130231.3035-1-grygorii.strashko@ti.com> <20160914130231.3035-4-grygorii.strashko@ti.com> <20160914135214.GA28592@localhost.localdomain> <606f7cfc-aa34-528b-df04-7a60a9695425@ti.com> <20160914203217.GD12195@netboy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 11:37:45PM +0300, Grygorii Strashko wrote: > The problem is that if cpts not initialized than pinter on > cpts (in consumer/parent driver - NETCP) will be NULL. You made that problem with your "clean up" in this series. Previously, cpts was always allocated. > So, rx_enable will be unaccessible and cause crash :( So just make sure cpts is initialized. Thanks, Richard