From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkN0P-00030n-Ct for qemu-devel@nongnu.org; Wed, 14 Sep 2016 23:06:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkN0M-0000IZ-Bx for qemu-devel@nongnu.org; Wed, 14 Sep 2016 23:06:29 -0400 Date: Thu, 15 Sep 2016 11:48:13 +1000 From: David Gibson Message-ID: <20160915014812.GN15077@voom.fritz.box> References: <1473832442-17762-1-git-send-email-nikunj@linux.vnet.ibm.com> <1473832442-17762-4-git-send-email-nikunj@linux.vnet.ibm.com> <20160915002531.GE15077@voom.fritz.box> <1473903661.8689.354.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PxiMezDaJQClLw92" Content-Disposition: inline In-Reply-To: <1473903661.8689.354.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH v4 3/3] target-ppc: tlbie/tlbivax should have global effect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Nikunj A Dadhania , qemu-ppc@nongnu.org, alex.bennee@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net --PxiMezDaJQClLw92 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2016 at 11:41:01AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-15 at 10:25 +1000, David Gibson wrote: > > >=A0 void helper_booke206_tlbivax(CPUPPCState *env, target_ulong > > address) > > >=A0 { > > > -=A0=A0=A0 PowerPCCPU *cpu =3D ppc_env_get_cpu(env); > > > +=A0=A0=A0 CPUState *cs; > > >=A0=A0 > > >=A0=A0=A0=A0=A0 if (address & 0x4) { > > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* flush all entries */ > > > @@ -2774,11 +2774,15 @@ void helper_booke206_tlbivax(CPUPPCState > > *env, target_ulong address) > > >=A0=A0=A0=A0=A0 if (address & 0x8) { > > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* flush TLB1 entries */ > > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 booke206_invalidate_ea_tlb(env, 1, address= ); > > > -=A0=A0=A0=A0=A0=A0=A0 tlb_flush(CPU(cpu), 1); > > > +=A0=A0=A0=A0=A0=A0=A0 CPU_FOREACH(cs) { > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 tlb_flush(cs, 1); > > > +=A0=A0=A0=A0=A0=A0=A0 } > > >=A0=A0=A0=A0=A0 } else { > > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* flush TLB0 entries */ > > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 booke206_invalidate_ea_tlb(env, 0, address= ); > > > -=A0=A0=A0=A0=A0=A0=A0 tlb_flush_page(CPU(cpu), address & MAS2_EPN_MA= SK); > > > +=A0=A0=A0=A0=A0=A0=A0 CPU_FOREACH(cs) { > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 tlb_flush_page(cs, address & MAS2_= EPN_MASK); > > > +=A0=A0=A0=A0=A0=A0=A0 } > >=20 > > Why are these explicit CPU_FOREACH()s instead of using the flags > > you've just bui >=20 > Because we haven't converted BookE to lazy TLB flushing yet... Ah, right. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --PxiMezDaJQClLw92 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJX2f3cAAoJEGw4ysog2bOSHTMQALBOY0g9XsQ6g4EkP5x0vSXe bC0RwK+866Hav0JkhJ80DXhzGrk2enLb3nU2bzIzmkkY4PmDhpolHBn4MaGZyopV ROuLTv/Kvg74QmJBAHHT72CKIoWiEOKDbBxigPgE1tFgHcNe/OehlI+uWTZoEH5d XcXYe9/6WG2XYqVwPvvKgI9J8OE9gQaDlHK+2xCV/TO7pTlJMQ9YlYPAOMqtQTWn rODyl4GEm0fbDCXAR3RSw77eLYn+sa/YOQga4GF6+ALF9tUSLtvFbkGgdyAFQjgK jRwa0xjHIiXpDYG0bG6tBA3WkzqNZY4G7ivYYjf3t1ZIxceKtjAr1M8O99jfSHCY TUnT8XUwCCOb7r9N0uDqebX/5sRwGoiE42F5k3xam8Ig6jTtL+h3Os0YJCyUAPhv i1IicODbvfL23Sivi3Ojykw/anl1GbEY9UGUJg143PSEmgmPTozxNG770m37LUyo 5wIx4QT1I7Whm7zxXMx5mHqGDJSY6jvzMHmsJrMX8gNeD4TGN/E30ZoBaUqLzoRh Z6zWvOw1n6IkOIEFwvk4YsawpxNYhQuxHr1A4JAymN1K0gEFfR+wjqT8qrARLut0 yhWFvoo2CUgHu/mfjqsx/E2Xha1w0MACkSaMCsSJ/PNkE4dHOYfwj14VOLLNA1eb m2JFi0ajAwW8sDEIS6lV =rQrb -----END PGP SIGNATURE----- --PxiMezDaJQClLw92--