All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
	fdmanana@gmail.com, mfasheh@suse.de
Subject: Re: [PATCH v6 1/6] fstests: common: Introduce _post_mount_hook for btrfs
Date: Thu, 15 Sep 2016 14:24:04 +1000	[thread overview]
Message-ID: <20160915042404.GS22388@dastard> (raw)
In-Reply-To: <20160914015527.10274-2-quwenruo@cn.fujitsu.com>

On Wed, Sep 14, 2016 at 09:55:22AM +0800, Qu Wenruo wrote:
> Introduce _post_mount_hook(), which will be executed after mounting
> scratch/test.
> 
> It's quite useful for fs(OK, only btrfs yet, again) which needs to
> use ioctl other than mount option to enable some of its feature.

Just implement a _btrfs_mount() function (similar to
_overlay_mount()) to do btrfs specific things at mount time.
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
> ---
>  common/rc | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 23c007a..631397f 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -321,6 +321,27 @@ _overlay_scratch_unmount()
>  	$UMOUNT_PROG $SCRATCH_MNT
>  }
>  
> +_run_btrfs_post_mount_hook()
> +{
> +	mnt_point=$1
> +	for n in $ALWAYS_ENABLE_BTRFS_FEATURE; do

What's this magic, undefined, undocumented variable?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-09-15  4:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14  1:55 [PATCH v6 0/6] Btrfs in-band de-duplication test cases Qu Wenruo
2016-09-14  1:55 ` [PATCH v6 1/6] fstests: common: Introduce _post_mount_hook for btrfs Qu Wenruo
2016-09-15  4:24   ` Dave Chinner [this message]
2016-09-19  4:08     ` Qu Wenruo
2016-09-14  1:55 ` [PATCH v6 2/6] fstests: common: rename _require_btrfs to _require_btrfs_subcommand Qu Wenruo
2016-09-14  1:55 ` [PATCH v6 3/6] fstests: Add btrfs dedupe post mount hook Qu Wenruo
2016-09-14  1:55 ` [PATCH v6 4/6] fstests: btrfs: Add basic test for btrfs in-band de-duplication Qu Wenruo
2016-09-14  1:55 ` [PATCH v6 5/6] fstests: btrfs: Add testcase for btrfs dedupe and metadata balance race test Qu Wenruo
2016-09-14  1:55 ` [PATCH v6 6/6] fstests: btrfs: Test inband dedupe with data balance Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915042404.GS22388@dastard \
    --to=david@fromorbit.com \
    --cc=fdmanana@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mfasheh@suse.de \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.