From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933626AbcIOF7z (ORCPT ); Thu, 15 Sep 2016 01:59:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48740 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756147AbcIOF7y (ORCPT ); Thu, 15 Sep 2016 01:59:54 -0400 Date: Thu, 15 Sep 2016 07:56:30 +0200 From: Greg KH To: Aidan Thornton Cc: Linux Kernel Mailing List , linux-usb@vger.kernel.org, m.othacehe@gmail.com, david.ward@ll.mit.edu, johan@kernel.org, pberger@brimson.com, WCH Tech Group , konstantin.shkolnyy@gmail.com, greg@chown.ath.cx Subject: Re: =?utf-8?B?6L2s5Y+ROiBbUEFUQ0g=?= =?utf-8?Q?=5D?= usb: serial: update CH34x driver in drivers/usb/serial Message-ID: <20160915055630.GA17039@kroah.com> References: <002401d1cddb$2f70ab60$8e520220$@com> <20160624150951.GA5719@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 12:03:48AM +0100, Aidan Thornton wrote: > On 24 Jun 2016 16:10, "Greg KH" wrote: > > > > On Fri, Jun 24, 2016 at 01:42:24PM +0800, WCH Tech Group wrote: > > >       There are several reasons why we decided to revoke the old one after > > > communicating with the author of > > > ch341.c (Frank A Kingswood ), first of > all > > > we want the driver to support both ch341 and > > > ch340 chips, so we changed the driver name from "ch341.c" to "ch34x.c", > > > > No need to rename the driver to support multiple chips.  Keep it the > > same name, and just add the new device support.  That's how we do it for > > lots and lots of Linux drivers, the name doesn't really matter that > > much (look at the option.c driver for one such example.) > > > > > secondly the new driver and old one are coded > > > by different authors, in fact there's no connection between them. > > > > Ok, but the functionality is the same, so please just fix up the > > existing driver to add support for the new device, and fix any existing > > bugs. > > > > In Linux you don't get to just delete a working driver, you have to > > evolve code over time, sending patches that do one logical thing at a > > time so that people can properly review them.  Your patch is not how > > this is supposed to happen at all. > > > > So please just break up your changes into small logical ones, and send a > > series of patches adding the new device support and fix up any known > > bugs. > > > > After that is all done, if you _really_ want to rename the driver, then > > we can discuss that, but first do the work to evolve the driver, as that > > is much more difficult. > > > > thanks, > > > > greg k-h > > It looks like someone by the name of Grigori Goronzy (CCed) had a patch series > or four attempting to do this that just never went anywhere like all the other > attempts. Might be worth someone talking to him or looking at his patches. Do you have a pointer to those patches on the mailing list? Why were they rejected? > Seriously, this is... I was considering trying to get parity support merged so > I don't have to keep patching it in, but it feels like a total waste of effort > at this point after seeing all the other attempts. No reason you can't take those patches and fix them up and resend them, right? thanks, greg k-h