On Mon, Sep 12, 2016 at 07:07:42PM +0300, Ram Amrani wrote:

> +++ b/drivers/infiniband/hw/qedr/qedr_hsi_rdma.h
> @@ -150,6 +150,12 @@ struct rdma_rq_sge {
>  	struct regpair addr;
>  	__le32 length;
>  	__le32 flags;
> +#define RDMA_RQ_SGE_L_KEY_MASK      0x3FFFFFF
> +#define RDMA_RQ_SGE_L_KEY_SHIFT     0
> +#define RDMA_RQ_SGE_NUM_SGES_MASK   0x7
> +#define RDMA_RQ_SGE_NUM_SGES_SHIFT  26
> +#define RDMA_RQ_SGE_RESERVED0_MASK  0x7
> +#define RDMA_RQ_SGE_RESERVED0_SHIFT 29
>  };

It is interesting twist to mix defines and structs together.