From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611AbcIONLH (ORCPT ); Thu, 15 Sep 2016 09:11:07 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58593 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbcIONK6 (ORCPT ); Thu, 15 Sep 2016 09:10:58 -0400 Date: Thu, 15 Sep 2016 15:09:23 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, yuyang.du@intel.com, Morten.Rasmussen@arm.com, linaro-kernel@lists.linaro.org, dietmar.eggemann@arm.com, pjt@google.com, bsegall@google.com Subject: Re: [PATCH 3/7 v3] sched: factorize PELT update Message-ID: <20160915130923.GR5008@twins.programming.kicks-ass.net> References: <1473666472-13749-1-git-send-email-vincent.guittot@linaro.org> <1473666472-13749-4-git-send-email-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473666472-13749-4-git-send-email-vincent.guittot@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 09:47:48AM +0200, Vincent Guittot wrote: > @@ -3690,7 +3658,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued) > /* > * Ensure that runnable average is periodically updated. > */ > - update_load_avg(curr, 1); > + update_load_avg(curr, 1, 0); > update_cfs_shares(cfs_rq); > I would find something like: update_load_avg(curr, UPDATE_TG), eg, make the second argument a bitflag instead of two arguments, much more readable. Do however check that it doesn't generate retarded code if you do that.