From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, longpeng2@huawei.com,
marcel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine
Date: Thu, 15 Sep 2016 11:19:09 -0300 [thread overview]
Message-ID: <20160915141909.GA6002@thinpad.lan.raisama.net> (raw)
In-Reply-To: <1473847310-129729-2-git-send-email-imammedo@redhat.com>
On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote:
> commit (a4d3c834 pc: Add 2.8 machine) didn't ammend
> PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in
>
> {\
> .driver = "virtio-pci",\
> .property = "page-per-vq",\
> .value = "on",\
> },
>
> and
>
> {\
> .driver = TYPE_X86_CPU,\
> .property = "l3-cache",\
> .value = "off",\
> },
>
> being ignored and as result change PC_COMPAT_2_6 behaviour.
>
[...]
> #define PC_COMPAT_2_6 \
> + PC_COMPAT_2_7 \
> HW_COMPAT_2_6 \
> {\
> .driver = "fw_cfg_io",\
Isn't this supposed to be unnecessary since commit bacc344c
("machine: add properties to compat_props incrementaly")?
--
Eduardo
next prev parent reply other threads:[~2016-09-15 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:01 [Qemu-devel] [PATCH 0/2] pc: fixes broken compat logic Igor Mammedov
2016-09-14 10:01 ` [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine Igor Mammedov
2016-09-14 11:32 ` Marcel Apfelbaum
2016-09-15 14:19 ` Eduardo Habkost [this message]
2016-09-15 15:18 ` Michael S. Tsirkin
2016-09-16 8:03 ` Igor Mammedov
2016-09-14 10:01 ` [Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types Igor Mammedov
2016-09-14 11:35 ` Marcel Apfelbaum
2016-09-15 14:23 ` Eduardo Habkost
2016-09-16 8:08 ` Igor Mammedov
2016-09-16 11:31 ` Eduardo Habkost
2016-09-18 0:28 ` [Qemu-devel] [PATCH 0/2] pc: fixes broken compat logic Longpeng (Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915141909.GA6002@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=longpeng2@huawei.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.