From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbcIOOqV (ORCPT ); Thu, 15 Sep 2016 10:46:21 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46540 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752913AbcIOOqF (ORCPT ); Thu, 15 Sep 2016 10:46:05 -0400 Date: Thu, 15 Sep 2016 15:45:53 +0100 From: Mark Brown To: Greg KH Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, Johan Hovold , Rui Miguel Silva , Laurent Pinchart , Sandeep Patil , Matt Porter , John Stultz , Rob Herring , Viresh Kumar , Alex Elder , David Lin , "Bryan O'Donoghue" , Vaibhav Agarwal , Mark Greer Message-ID: <20160915144553.GA15697@sirena.org.uk> References: <20160914100949.GA6179@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <20160914100949.GA6179@kroah.com> X-Cookie: All models over 18 years of age. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [GIT PULL] Greybus driver subsystem for 4.9-rc1 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 14, 2016 at 12:09:49PM +0200, Greg KH wrote: > I'll send out a follow-up set of "simple" patches that just add the > files to the kernel tree, to give people an idea of the code involved. > Overall, it's a tiny stand-alone driver subsystem, only 37k lines, that > implements a protocol which allows for "generic" cameras, audio devices, > and other class type devices, as well as a bridged "physical" layer > protocol to talk to serial, spi, uart, pwm, gpio, i2c, and even USB host Just emphasizing what Mark Rutland said complete NACK, in particular the drivers for functions have not been posted upstream at all (and it's concerning that they're all being added under drivers/greybus rather than within the relevant subsystem like we do normally). I've not looked at the code as it has not been submitted but given that and that the reason I found this pull request was an ASoC contributor who had seen it and looked at the code going "oh dear, greybus..." on IRC I'm very concerned. Sending a pull request for code that's never been seen upstream seems completely premature. --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJX2rQgAAoJECTWi3JdVIfQAiIH/0KuotFQHFei8mDQJB5kGDzP 9G02p+xLD+XnCm6Zp01KPVaTeyTkHuJXI6E9CapOS/eIYnjryrtOipCRPW8ES+/k LEXux65bVfLkVo0ii6DyLaMaeoYrphXK7HqUT1Mk9QLzvt5zEzGRhOG8X0Otzwj8 VyLsjZSgOyxHShECWP+i1iUdEewI9hnuiQl1AeS8lX+0HDlUPVQF5EsPloYh7CMW oJfEUXbs3Hg6i3b9HaExCTHhOU0cWcc4jgL2gEl7+ifiyiO2q/uF0T9oT+ju56GB fTfm/F1GzLz7Tn+lCEOKZRLQuDTQUErHm4p0KEVEVkP7v30atLIuI9WMWzNmRRY= =hJ7x -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--