From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbcIOOrj (ORCPT ); Thu, 15 Sep 2016 10:47:39 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46612 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbcIOOrb (ORCPT ); Thu, 15 Sep 2016 10:47:31 -0400 Date: Thu, 15 Sep 2016 15:47:20 +0100 From: Mark Brown To: Viresh Kumar Cc: Lee Jones , linaro-kernel@lists.linaro.org, Krzysztof =?utf-8?Q?Koz=C5=82owski?= , patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20160915144720.GK27974@sirena.org.uk> References: <9f4aa8441344137272549e65d81c7fe65e37a8a8.1473938123.git.viresh.kumar@linaro.org> <2b050796dd4230f8b60ed39d32716c2fec5b44d0.1473938123.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4vpci17Ql0Nrbul2" Content-Disposition: inline In-Reply-To: <2b050796dd4230f8b60ed39d32716c2fec5b44d0.1473938123.git.viresh.kumar@linaro.org> X-Cookie: Even bytes get lonely for a little bit. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4vpci17Ql0Nrbul2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 15, 2016 at 04:47:01PM +0530, Viresh Kumar wrote: > Fix the kernel warnings and crashes by moving away from managed > regulator bulk get API by using regulator_bulk_get() and explicitly > calling regulator_put() for all the supplies in exit paths. Moving away from regulator bulk get to regulator bulk get? > - ret = devm_regulator_bulk_get(wm8994->dev, wm8994->num_supplies, > + ret = regulator_bulk_get(wm8994->dev, wm8994->num_supplies, > wm8994->supplies); > +err_regulator_put: > + for (i = wm8994->num_supplies - 1; i >= 0; i--) > + regulator_put(wm8994->supplies[i].consumer); Why are you unwinding regulator_bulk_get() with an open coded regulator_bulk_put()? Also please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative then it's usually better to pull out the relevant sections. --4vpci17Ql0Nrbul2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJX2rR3AAoJECTWi3JdVIfQTsAH/R9W3JNl0aNfVL78rw9UiGMA y/urWQIm+yw0TVXNDTnVmFt6/azzuO48V4P301WLH/BkU9m3CHIC9r3ZCtXKF2FW G5UfAcF1ESc+wXLo17QVR0VRefjq7svdctbas8h2YvoWebPVQ378Vucff0rybR99 cwCw4TERfCOSz6ETnqEMjd7q0frkd3zAwIRVuzOQqXuoHsBgO1L56oCaMG4sN1qf aDy80wShpGUoaxgXpbLX+kF4/LOg6ZZtG5gz9hkj1dfL0E7hqJ61FJiDOFmWMytk nae3ZySslYiEJ5E2kf0kqgANz3PGtkwYG+pnhQqNbV2z0/vy02T/DXwyu5TjqjE= =YqPC -----END PGP SIGNATURE----- --4vpci17Ql0Nrbul2--