From: Mark Brown <broonie@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Lee Jones" <lee.jones@linaro.org>,
linaro-kernel@lists.linaro.org,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API
Date: Thu, 15 Sep 2016 16:47:01 +0100 [thread overview]
Message-ID: <20160915154701.GN27974@sirena.org.uk> (raw)
In-Reply-To: <20160915150844.GE30169@vireshk-i7>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Thu, Sep 15, 2016 at 08:38:44PM +0530, Viresh Kumar wrote:
> On 15-09-16, 15:47, Mark Brown wrote:
> > On Thu, Sep 15, 2016 at 04:47:01PM +0530, Viresh Kumar wrote:
> > > Fix the kernel warnings and crashes by moving away from managed
> > > regulator bulk get API by using regulator_bulk_get() and explicitly
> > > calling regulator_put() for all the supplies in exit paths.
> > Moving away from regulator bulk get to regulator bulk get?
> Moving away from "managed" regulator bulk get to regulator bulk get?
> Isn't this how we call the devm_* APIs as?
That's really unclearly worded (especially since one uses the function
name and the other doesn't).
> > > - ret = devm_regulator_bulk_get(wm8994->dev, wm8994->num_supplies,
> > > + ret = regulator_bulk_get(wm8994->dev, wm8994->num_supplies,
> > > wm8994->supplies);
> > > +err_regulator_put:
> > > + for (i = wm8994->num_supplies - 1; i >= 0; i--)
> > > + regulator_put(wm8994->supplies[i].consumer);
> > Why are you unwinding regulator_bulk_get() with an open coded
> > regulator_bulk_put()?
> Because there is no regulator_bulk_put(). Should I add it?
I mean regulator_bulk_free() there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-09-15 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 11:17 [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Viresh Kumar
2016-09-15 11:17 ` [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar
2016-09-15 12:34 ` Charles Keepax
2016-09-15 14:47 ` Mark Brown
2016-09-15 15:08 ` Viresh Kumar
2016-09-15 15:47 ` Mark Brown [this message]
2016-09-15 12:31 ` [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915154701.GN27974@sirena.org.uk \
--to=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.