All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ville Ranki <ville.ranki@iki.fi>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: joydev - Recognize joysticks with Z axis as joysticks.
Date: Thu, 15 Sep 2016 15:35:48 -0700	[thread overview]
Message-ID: <20160915223548.GA29897@dtor-ws> (raw)
In-Reply-To: <1472134610-6438-1-git-send-email-ville.ranki@iki.fi>

On Thu, Aug 25, 2016 at 05:16:50PM +0300, Ville Ranki wrote:
> Current implementation of joydev's input_device_id
> table recognizes only devices with ABS_X, ABS_WHEEL
> or ABS_THROTTLE axes as joysticks.
> 
> There are joystick devices that do not have those axes,
> for example TRC Rudder device. The device in question
> has ABS_Z, ABS_RX and ABS_RY axes causing it not being
> detected as joystick.
> 
> This patch adds ABS_Z to the input_device_id list
> allowing devices with ABS_Z axis to be detected
> correctly.
> 
> Signed-off-by: Ville Ranki <ville.ranki@iki.fi>

Applied, thank you.

Although I wonder if we could not move joydev implementation to
userspace in the long run.

Thanks.

-- 
Dmitry

      parent reply	other threads:[~2016-09-15 22:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 14:16 [PATCH] Input: joydev - Recognize joysticks with Z axis as joysticks Ville Ranki
2016-08-25 16:45 ` Dmitry Torokhov
2016-08-25 20:56   ` Ville Ranki
2016-09-02  9:11     ` Ville Ranki
2016-09-15 14:18       ` Ville Ranki
2016-09-15 22:35 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915223548.GA29897@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=ville.ranki@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.