From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ycheng@google.com, wygivan@google.com
Subject: Re: [PATCH net-next] tcp: fix a stale ooo_last_skb after a replace
Date: Fri, 16 Sep 2016 04:13:59 -0400 (EDT) [thread overview]
Message-ID: <20160916.041359.1883591254375953017.davem@davemloft.net> (raw)
In-Reply-To: <1473832505.22679.17.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 13 Sep 2016 22:55:05 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> When skb replaces another one in ooo queue, I forgot to also
> update tp->ooo_last_skb as well, if the replaced skb was the last one
> in the queue.
>
> To fix this, we simply can re-use the code that runs after an insertion,
> trying to merge skbs at the right of current skb.
>
> This not only fixes the bug, but also remove all small skbs that might
> be a subset of the new one.
>
> Example:
>
> We receive segments 2001:3001, 4001:5001
>
> Then we receive 2001:8001 : We should replace 2001:3001 with the big
> skb, but also remove 4001:50001 from the queue to save space.
>
> packetdrill test demonstrating the bug
...
> Fixes: 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Yuchung Cheng <ycheng@google.com>
Applied.
prev parent reply other threads:[~2016-09-16 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 5:55 [PATCH net-next] tcp: fix a stale ooo_last_skb after a replace Eric Dumazet
2016-09-16 8:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916.041359.1883591254375953017.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wygivan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.