From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbcIPIj0 (ORCPT ); Fri, 16 Sep 2016 04:39:26 -0400 Received: from mail-by2nam03on0044.outbound.protection.outlook.com ([104.47.42.44]:58912 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751180AbcIPIjW (ORCPT ); Fri, 16 Sep 2016 04:39:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Fri, 16 Sep 2016 10:39:01 +0200 From: Jan Glauber To: Will Deacon CC: Mark Rutland , , Subject: Re: [PATCH v2 0/5] Cavium ThunderX uncore PMU support Message-ID: <20160916083901.GC3069@hardcore> References: <20160628102419.GA5425@arm.com> <20160628140459.GA27541@hardcore> <20160704101132.GC1639@arm.com> <20160916075523.GJ3380@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160916075523.GJ3380@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [88.67.134.51] X-ClientProxiedBy: VI1PR0901CA0083.eurprd09.prod.outlook.com (10.167.203.179) To BN3PR07MB2577.namprd07.prod.outlook.com (10.167.4.154) X-MS-Office365-Filtering-Correlation-Id: 882e7032-376b-4f00-3143-08d3de0cf06d X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2577;2:DlVlF2pjNzCNu0thf2Z4dGBp5sHTVAh4/KDcv1RgXNm9jYuR74h/M2ZePsqLtXxvATdqn7241tpF5USiLMxBd+YcTBJ9Jte1QHyyh90Nq04wULI/ylYvYUSU1T6nk8G56qCF+MALeflMDd/qCEAAVMU5caaqYsYXpB1GT475suZyOgXv/mx0t0IevEa4YcU+;3:sE3liT+HcpsFzUwAbcHbToZP7mnNceCvQBhm59NCAGBLe0E09+t8wOAYW1P2/4zn+IvqnPUiOVz5x4f5JN3RHcXEIwwSYB+NvcLj0jUMMQdMYK4xeARAOh/J0BTz3s/1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2577; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2577;25:IMt7UZzYPnpETwWTijprd5LfoMatVQtYU8ikjVC9/6Sv5tVexAevMLsLcYgjQKJX1+9xa9KIwD9iuGthd94fm4EYi6CM4sWYci0DqPOUFppgCan6yHWKiLvE/Sw4xXK1Nck7gg7ZCCGvtk5GThkmMlcNzRO89qWBwwnkqTE0fixcAyrlE7LCGssDjt8wchBEzhEziX1vk79LNPo61nQstO3/liza8vRyRzUQgNzYBNvyTg83UCFMVYbSKpMfTUoN5er2/suEm5jzbNfBuiNYj5sWRM9oXH3ZTjYPslyBKiP/N9X/AIkMWTvTF4Qc/BIXRzycOjHoIJu/yerdd2l00xcrrk0X71X5eZ860+tIwTP7L+ZJE17iaxrx+9NrV4HmTNmu402re1qd06y1aXrKxeC+6z0AUBrKB3QvNlaSpB4KMpqcxfANe8u0HSo+SG8oqhBSSThmjjpyFWIyZP5raL13qSsDLBVR4iQG3W5tJpV3ECpdI9nEHSYCbrW15Y3qt5Ya4me4eUtc420MysxttkRvYDKZuZTTc0l5GsynUVxcguL3lkEuP8A5YkBYzufDdRWbRE1GLwbxMA1/SeC5lfG2Xj0kJlnzoU/jOmwu32pyXXq+cf1gsHpIeICIIGaIJc9lRVhN/EtYGBSfBvNUPLQd+DA6WsuhNq5WoP6tTwRZX6f2YhHV8HrIwoXs3kRf9GV5ATlfWIKuRELrQFSCGA==;31:v0Cgrufc1d4bz/tjcGocrRtAs1hbMMwXwLFKHmwgzgaN86gV0MaU9BWQz/Mszyl0kJQ6dekE2M7Gi3Bn2DjlDzxgeI8OQZs6MRG7kd+Y+3U/5E/bxPKVWhhc8WTW7+1t+2wx3obNo89u6seHUJcAYqRF0oD1BHxt01qi/xFNGgO4Es+qSd/jn3Xv7ahHiCQJUrzInaNJElf6oja9KX+q3rgrOvzAPKDB7Nslax2cqug= X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2577;20:xpPaXCcMTUAJUvDuCZjZ6Jt7fg720e7WmZBnuSETrdfyPpu+ux9YhoY+L5oxwo3wi4L+E8G/vctfDaPUiNrmHxRWf3R7YxUI/tDw2CQrdw3MAPkDobvn2bJ182qM+9Xgk/8vtcNEzaxnv0drusQCJ9r4C1xTO5cJo9+JqQU+UZJ4TO2llzfiKtt8cpC9sT3lYp6BBm4lhUj9dzEViQ4Uu316DXvm7bpjfCL4kbX6/n9DElnReGoCREqyxwdb0oP8QJNGUOVWO1tGqGScimZU7BbcSAifOOW47R5NNQS3IhRhBLKAA+K3fUtSifTyJHMQeatL86ZtwbnGwNoHu2R3Swq+m7mT+UfdcPEuRLMfmrZyVXAKeYYOjVkfHXE0naecoX6mLgp17ygWIOUux2ZsZ4Nn7wVqYe6QoN1esz8z3w5sFKJ+StRavM+i5WuEb0QTmxutvVGDqSkNmwpJZH57xmHF/NIl+CR7M8TPhBmk5OF6XQ5ctM03rQG6oZQ1s8Pd1kVSrVKBXIEf/xxLHitf9FOSfTHrWQxESpRL10NUqmsUl350jiIwUqaUVqv9pUMLdPyxRL4cbO7I33CuVTrBKkU0udQgTGFyGnfckL5Ieao= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN3PR07MB2577;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2577; X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2577;4:JtpRqX7dKkyuyfkmbIcHayifZrT2Z29pLZdBg2HtMYByttirKIkDOPZ17w8BErSo7oWPdDo9Rupfp0WTS8Sj8TG06zF5zlweITaAERdJwb5BUFZlrww0lQM/0DROcFmqtkXPwhLxghDSb3PwE4OVnnVQFtqwyXU/8gyspeoLne33v5YocaOe1DYfqZPzm9Oov0L1JbD0Rkgj5MtdIA0jI6DMlJAKIIiTfVBST5APZbkHwfwQVSM6zzhvR7CtlsGIVvE9qATHY88dTCLc2ZoEGTpxGYklBT1bcHkENDzaoyhNre55/Im3YJWjLxZizhVjiRVcUcTessXGQzhqb/zVfUBFRgSQo4HCe3+ZM0VMxq2/ATRhzRLf0sM4sstf6VQWRgQiXdhUc5z88JSr/bsZsA== X-Forefront-PRVS: 0067A8BA2A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(979002)(6009001)(7916002)(24454002)(199003)(189002)(92566002)(54356999)(76176999)(2906002)(50986999)(586003)(42186005)(77096005)(6116002)(3846002)(1076002)(23726003)(4326007)(93886004)(97736004)(4001350100001)(9686002)(189998001)(97756001)(83506001)(81156014)(66066001)(8676002)(105586002)(5660300001)(50466002)(81166006)(106356001)(68736007)(47776003)(2950100001)(110136003)(33716001)(33656002)(101416001)(305945005)(46406003)(7846002)(7736002)(18370500001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2577;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR07MB2577;23:nBOrRv0RAdtqC2aUYKc557vL3td1cw7SkoPXILEDV?= =?us-ascii?Q?/fTZUOjefetqfnsOE47b+YJnZIMmssQ3sMBOeYlTAZZs11QfqmWQm6yLPLHA?= =?us-ascii?Q?rKuv5U8zp5bIScItqyEYG9ELVu0oCN6i6gJrxWalrrhK4EKLcNUD4dvL2CQU?= =?us-ascii?Q?7MArVGeCTjHmSP2XBSVJ2viivlREDVr/YTu0amhYCrtG56ILtb6V1EhE4/xI?= =?us-ascii?Q?pEByJXIeVorPLfntjnCkqj3LC0sCi96TMJrgIJEt1oaBVwnhErg96CqOCKZ6?= =?us-ascii?Q?KyESLS1EPKd2ka9q8J/R95Uyxh9ggtyr7qpl2MX44rzw4YXTeAJ5mFj7pdsl?= =?us-ascii?Q?UrlNc5wQ7OXjnpRK3jK8tB+z777ruP8e6iC5bKEj+iVoaH8/pQpbUDwd6zwO?= =?us-ascii?Q?X5oMo4gM1kmPombuL7Op+FrA3TWug6RzjLd7MxfO9bNDynRer5EgpKEFvoj4?= =?us-ascii?Q?45LcYLfDvEpvGh2n4l/Q2GBFP0Bs01X6MO7RP2iMzokkCFLBifZRZubQL3eX?= =?us-ascii?Q?KXtpWa6r6hi4MEbC8mXrey2hkhzPjyHYIokVjMqoKHPtKFBJKfZ8rdoHgIEU?= =?us-ascii?Q?DCCWkNCSV95iNzs3NRFyJp3gYlKgRfz7HgzxuZAMlDnnKrhxnFJPKxVvQCdq?= =?us-ascii?Q?JKHL2Qd8xSjIjrfC4QAQX2f+i8UtNHzR6QzM/YPg4t+EVjyAQEJFeM98vcS9?= =?us-ascii?Q?kpD1VDiak1AnJc5B24RFKeluKzYLG3+060CwI3m7S/lrY6EXdo4v9oo7HhDv?= =?us-ascii?Q?U7mSMncUXybpnrFJaF8+4tPTBShNHOdzclwaCqUph0jvuGk/dlderSr1+/DQ?= =?us-ascii?Q?CJ7cKgANTir+El+5CpISzsye6jebA9VZVcvCrhMpEzfNH6nEfo5T3sgjkUC9?= =?us-ascii?Q?nGzOO+JyXf9n3Q7grbpFYt0zGmJqj/3noXCh3ea5DFVJie+8zWByr3rQgm6n?= =?us-ascii?Q?PYx+62o6dGtvhrrrZuaHeIlSt2oZv/SJ3t/MQOa3TQcsXGGPsX1awD+tLZcg?= =?us-ascii?Q?k1VrscIXyTJI8OaiFhDaGaSLirGASUhM74glppM2Y2ncnuiAboDomLNmVLtS?= =?us-ascii?Q?mndO6AvwfLr5U0mKiQZ+avd4Dfq6KIXstxAGAE+x39WnQwlWI03wPRHs8+z1?= =?us-ascii?Q?G0ggoTWaZIpk9Ju5z/fm9ZL1TIy8g9Nowbu0aqY3aqefMi5fIEa2jJQYVd1N?= =?us-ascii?Q?LBvF1GorMNNB/FeSy/EYIAVFR9MxVDN64GKg6opGEI5n3VJuLXv/a8xrDNky?= =?us-ascii?Q?3hFK5AYug/XhZecx7Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR07MB2577;6:SDvN/ZmZDgmUFCSAt2zA5T0/1UISGgSLf7fNTAmJuMRMaAQBb3mLifOcDOaPut/e+2Fb5GgCRl4a1rCMXAbAwGGfOKRcmudjg4hqL7Fq+B4r6l144CwM0V6sMeXP+zFv9EgAKwuZt5F9PdwQv/XclmJP7BvBhty2CKTuOzC/lE6Phbb8yfRfdKUKDbcYYexwEvOg7RDjiNRjjxiNVWlWKFjnkLwBFY6OTg9pWayMu6l1dHPo/wSv7eeu7y5vYPDgk9b37K5sjHUQQTOjRjUxy+HCjZ3OirnFsxNAFJUmjPg=;5:idqpcYFeePmphljORhuR2UhfRrlJSfiRzLUQLuAadvk8I4JATs4n65cCWNOwSnyg5PS6ZQ8eCTW6j+5jfxCW9sSpy2bCg8hBsjXHietVnvZbwJdN+sYF3SZz+S51o/ilu3DxkcqAOOUS3w327sR8vA==;24:fekihHlCJv16XLNWjJdg5v4HKkftaZEt/DzdmW97c2ADIi05qpRaGFkGH57YaDKmmN5X3NG5DZxQi1y90L/Lo68kgq1CXPX08YU/VddFrS8=;7:L/N/DFrmlCucUIVVM/YDsjpD4JxbTw2A7iDsqHf5pb96eZtYFCz8WjQTP8i0J9SzR1ycCWhlN08/R21gDXOn5VugRqo9OE/uixJx8YqYhfnyMPAsiI9H8eEb+gfjWTzhLFJQKB3cJJPCyhSQiRbv0rmxFzj76+nCuUA1f8QCemwU0VqKDltRr/HmUEb1+fM0wUyh4Boz11k+p4Zr3Ofx4EHDKl4ZBAPG3uCGIALB+j28MPOxTPzUGBSzAzY6/szR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2016 08:39:13.2914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2577 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2016 at 08:55:24AM +0100, Will Deacon wrote: > Hi Jan, > > On Mon, Jul 04, 2016 at 11:11:32AM +0100, Will Deacon wrote: > > On Tue, Jun 28, 2016 at 04:04:59PM +0200, Jan Glauber wrote: > > > On Tue, Jun 28, 2016 at 11:24:20AM +0100, Will Deacon wrote: > > > > On Wed, Mar 09, 2016 at 05:21:02PM +0100, Jan Glauber wrote: > > > > > This patch series provides access to various counters on the ThunderX SOC. > > > > > > > > > > For details of the uncore implementation see patch #1. > > > > > > > > > > Patches #2-5 add the various ThunderX specific PMUs. > > > > > > > > > > As suggested I've put the files under drivers/perf/uncore. I would > > > > > prefer this location over drivers/bus because not all of the uncore > > > > > drivers are bus related. > > > > > > > > What's the status of these patches? Were you planning to send a new > > > > version? > > > > > > I was half-way through with addressing Mark's review comments when > > > got side-tracked. > > > > > > The principle question these patches raised remains open though in my > > > opinion, how to determine the socket a device belongs to. > > > > > > There is no first-class interface to ask a device or the firmware > > > which socket the device lives on. > > > > > > The options I see are: > > > A) Using NUMA node information, depends on CONFIG_NUMA > > > B) Decoding the socket bits of the PCI BAR address > > > C) Using PCI topology information > > > > > > A is what I tried, but I agree that depending on CONFIG_NUMA is not a good > > > solution. B would be easy but looks not very future-proof. So option C > > > is what is left... > > > > Sorry to go full circle on this, but "depends on NUMA" sounds better > > than deriving NUMA topology from PCI to me. The only worry I have is if > > the NUMA information ends up being insufficient in the long-term, and we > > end up with a mixture of the three options above in order to figure out > > the PMU topology. > > > > As long as you're happy that the PMU:NUMA topology remains 1:1, then I > > have no objections. The moment you need extra hacks on the side, we should > > probably drop the NUMA dependency altogether and figure it out some other > > way. > > Any news on this series, or did I miss a v3? I was hoping to have this in > for 4.9, but it seems to have stalled :( > > Will No news, I'm afraid it is stalled on my side :( I'll try to get back to it, but not for 4.9. Jan From mboxrd@z Thu Jan 1 00:00:00 1970 From: jan.glauber@caviumnetworks.com (Jan Glauber) Date: Fri, 16 Sep 2016 10:39:01 +0200 Subject: [PATCH v2 0/5] Cavium ThunderX uncore PMU support In-Reply-To: <20160916075523.GJ3380@arm.com> References: <20160628102419.GA5425@arm.com> <20160628140459.GA27541@hardcore> <20160704101132.GC1639@arm.com> <20160916075523.GJ3380@arm.com> Message-ID: <20160916083901.GC3069@hardcore> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 16, 2016 at 08:55:24AM +0100, Will Deacon wrote: > Hi Jan, > > On Mon, Jul 04, 2016 at 11:11:32AM +0100, Will Deacon wrote: > > On Tue, Jun 28, 2016 at 04:04:59PM +0200, Jan Glauber wrote: > > > On Tue, Jun 28, 2016 at 11:24:20AM +0100, Will Deacon wrote: > > > > On Wed, Mar 09, 2016 at 05:21:02PM +0100, Jan Glauber wrote: > > > > > This patch series provides access to various counters on the ThunderX SOC. > > > > > > > > > > For details of the uncore implementation see patch #1. > > > > > > > > > > Patches #2-5 add the various ThunderX specific PMUs. > > > > > > > > > > As suggested I've put the files under drivers/perf/uncore. I would > > > > > prefer this location over drivers/bus because not all of the uncore > > > > > drivers are bus related. > > > > > > > > What's the status of these patches? Were you planning to send a new > > > > version? > > > > > > I was half-way through with addressing Mark's review comments when > > > got side-tracked. > > > > > > The principle question these patches raised remains open though in my > > > opinion, how to determine the socket a device belongs to. > > > > > > There is no first-class interface to ask a device or the firmware > > > which socket the device lives on. > > > > > > The options I see are: > > > A) Using NUMA node information, depends on CONFIG_NUMA > > > B) Decoding the socket bits of the PCI BAR address > > > C) Using PCI topology information > > > > > > A is what I tried, but I agree that depending on CONFIG_NUMA is not a good > > > solution. B would be easy but looks not very future-proof. So option C > > > is what is left... > > > > Sorry to go full circle on this, but "depends on NUMA" sounds better > > than deriving NUMA topology from PCI to me. The only worry I have is if > > the NUMA information ends up being insufficient in the long-term, and we > > end up with a mixture of the three options above in order to figure out > > the PMU topology. > > > > As long as you're happy that the PMU:NUMA topology remains 1:1, then I > > have no objections. The moment you need extra hacks on the side, we should > > probably drop the NUMA dependency altogether and figure it out some other > > way. > > Any news on this series, or did I miss a v3? I was hoping to have this in > for 4.9, but it seems to have stalled :( > > Will No news, I'm afraid it is stalled on my side :( I'll try to get back to it, but not for 4.9. Jan