From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 05/18] drm/i915: Move GEM activity tracking into a common struct reservation_object Date: Fri, 16 Sep 2016 12:40:14 +0100 Message-ID: <20160916114014.GI13394@nuc-i3427.alporthouse.com> References: <20160914065250.15482-1-chris@chris-wilson.co.uk> <20160914065250.15482-6-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DB386EA11 for ; Fri, 16 Sep 2016 11:40:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160914065250.15482-6-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMTQsIDIwMTYgYXQgMDc6NTI6MzdBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEluIHByZXBhcmF0aW9uIHRvIHN1cHBvcnQgbWFueSBkaXN0aW5jdCB0aW1lbGluZXMs IHdlIG5lZWQgdG8gZXhwYW5kIHRoZQo+IGFjdGl2aXR5IHRyYWNraW5nIG9uIHRoZSBHRU0gb2Jq ZWN0IHRvIGhhbmRsZSBtb3JlIHRoYW4ganVzdCBhIHJlcXVlc3QKPiBwZXIgZW5naW5lLiBXZSBh bHJlYWR5IHVzZSB0aGUgc3RydWN0IHJlc2VydmF0aW9uX29iamVjdCBvbiB0aGUgZG1hLWJ1Zgo+ IHRvIGhhbmRsZSBtYW55IGZlbmNlIGNvbnRleHRzLCBzbyBpbnRlZ3JhdGluZyB0aGF0IGludG8g dGhlIEdFTSBvYmplY3QKPiBpdHNlbGYgaXMgdGhlIHByZWZlcnJlZCBzb2x1dGlvbi4gKEZvciBl eGFtcGxlLCB3ZSBjYW4gbm93IHNoYXJlIHRoZSBzYW1lCj4gcmVzZXJ2YXRpb25fb2JqZWN0IGJl dHdlZW4gZXZlcnkgY29uc3VtZXIvcHJvZHVjZXIgdXNpbmcgdGhpcyBidWZmZXIgYW5kCj4gc2tp cCB0aGUgbWFudWFsIGltcG9ydC9leHBvcnQgdmlhIGRtYS1idWYuKQo+IAo+IENhdmVhdHM6Cj4g Cj4gICogYnVzeS1pb2N0bDogdGhlIG1vZGVybiBpbnRlcmZhY2UgaXMgY29tcGxldGVseSB0aHJv d24gYXdheSwKPiByZWdyZXNzaW5nIHVzIGJhY2sgdG8gYmVmb3JlCj4gCj4gY29tbWl0IGU5ODA4 ZWRkOTg2Nzk2ODA4MDRkZmJjNDJjNWVlOGYxYWE5MWY2MTcgW3YzLjEwXQo+IEF1dGhvcjogQ2hy aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gRGF0ZTogICBXZWQgSnVsIDQg MTI6MjU6MDggMjAxMiArMDEwMAo+IAo+ICAgICBkcm0vaTkxNTogUmV0dXJuIGEgbWFzayBvZiB0 aGUgYWN0aXZlIHJpbmdzIGluIHRoZSBoaWdoIHdvcmQgb2YgYnVzeV9pb2N0bAoKVGhlcmUgaXMg YW4gYWx0ZXJuYXRpdmUgaGVyZSwgYXMgd2UgY2FuIHdhbGsgdGhyb3VnaCB0aGUgb2JqLT5yZXN2 IGFuZApjb252ZXJ0ICppOTE1KiBmZW5jZXMgdG8gdGhlaXIgcmVzcGVjdGl2ZSByZWFkL3dyaXRl IGVuZ2luZXMuCgpIb3dldmVyLCB0aGlzIG1lYW5zIHRoYXQgYnVzeS1pb2N0bCBhbmQgd2FpdC1p b2N0bCgudGltZW91dD0wKSBhcmUgbm8KbG9uZ2VyIGVxdWl2YWxlbnQgYXMgdGhhdCBidXN5LWlv Y3RsIG1heSByZXBvcnQgYW4gb2JqZWN0IGFzIGlkbGUgYnV0CnN0aWxsIGhhcyBleHRlcm5hbCBy ZW5kZXJpbmcgKGFuZCBzbyB3YWl0LWlvY3RsLCBzZXQtdG8tZG9tYWluLWlvY3RsLApwcmVhZCwg cHdyaXRlIG1heSBzdGFsbCkuCgpXYWxraW5nIHRoZSByZXN2IG9iamVjdCBpcyBhbHNvIG1vcmUg ZXhwZW5zaXZlIHRoYW4gZG9pbmcgYSBzaW1wbGUgdGVzdC4KVGhvdWdoIHRoYXQgY2FuIGJlIG1p dGlnYXRlZCBsYXRlciBieSBvcGVuY29kaW5nIHRoZSB0ZXN0IChvbmNlIHdlIGNhbgpkbyB0aGUg d2hvbGUgYnVzeS1pb2N0bCB1bmRlciBvbmx5IFJDVSBwcm90ZWN0aW9uIHRoYXQgbWFrZXMgbW9y ZQpzZW5zZSkuIEJ1dCBpdCBtYWtlcyBidXN5LWlvY3RsIHNsb3dlciB0aGFuIGlkZWFsLCBhbmQg YnVzeS1pb2N0bCBpcwpoaWdoIGZyZXF1ZW5jeSAoc28gbG9uZyBhcyB3ZSBrZWVwIGF2b2lkaW5n IHN0cnVjdF9tdXRleCwgdGhlIGRpZmZlcmVuY2UKaXMgbGlrZWx5IG9ubHkgdmlzaWJsZSBpbiB0 aGUgbWljcm9iZW5jaG1hcmtzKS4KClBybzogd2Uga2VlcCB0aGUgZmluZXNlIG9mIGJlaW5nIGFi bGUgdG8gcmVwb3J0IHdoaWNoIGVuZ2luZXMgYXJlIGJ1c3kKQ29uOiBub3QgZXF1aXZhbGVudCB0 byB3YWl0LWlvY3RsLCBwb2xsaW5nIHRoZSBkbWFidWYsIGV0Yy4KClRoYXQgd2UgaGF2ZSBhbHRl cm5hdGl2ZSBtZWNoYW5pc21zIHRvIGNoZWNrIG1heSBiZSBjb25zaWRlcmVkIGEgZ29vZAp0aGlu ZywgaS5lLiB3ZSBjYW4gbWlncmF0ZSB0byB1c2luZyB3YWl0LWlvY3RsIGZvciB0aGUgZ2VuZXJh bCBhbSBJCmdvaW5nIHRvIHN0YWxsIHRlc3QsIGFuZCB1c2luZyBidXN5LWlvY3RsIGZvciBlbmdp bmUgc2VsZWN0aW9uLiBJIHRoaW5rCkkgYW0gbGVhbmluZyB0b3dhcmRzIGtlZXBpbmcgdGhlIEFC SSBtb3JlIG9yIGxlc3MgaW50YWN0IGZvciB0aGUgdGltZQpiZWluZy4gVGhvdWdoIHdlIGFyZSBn ZXR0aW5nIHByZXR0eSBjbG9zZSB0byBpdHMgbGltaXQgb24gTlVNX0VOR0lORVMuCgppbnQKaTkx NV9nZW1fYnVzeV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAogICAg ICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKewogICAgICAgIHN0cnVjdCBk cm1faTkxNV9nZW1fYnVzeSAqYXJncyA9IGRhdGE7CiAgICAgICAgc3RydWN0IGRybV9pOTE1X2dl bV9vYmplY3QgKm9iajsKICAgICAgICBzdHJ1Y3QgZmVuY2UgKipzaGFyZWQsICpleGNsOwogICAg ICAgIHVuc2lnbmVkIGludCBjb3VudCwgaTsKICAgICAgICBpbnQgcmV0OwoKICAgICAgICByZXQg PSAtRU5PRU5UOwogICAgICAgIG9iaiA9IGk5MTVfZ2VtX29iamVjdF9sb29rdXAoZmlsZSwgYXJn cy0+aGFuZGxlKTsKICAgICAgICBpZiAob2JqKSB7CiAgICAgICAgICAgICAgICByZXQgPSByZXNl cnZhdGlvbl9vYmplY3RfZ2V0X2ZlbmNlc19yY3Uob2JqLT5yZXN2LAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZleGNsLCAmY291bnQsICZz aGFyZWQpOwogICAgICAgICAgICAgICAgaTkxNV9nZW1fb2JqZWN0X3B1dF91bmxvY2tlZChvYmop OwogICAgICAgIH0KICAgICAgICBpZiAodW5saWtlbHkocmV0KSkKICAgICAgICAgICAgICAgIHJl dHVybiByZXQ7CgogICAgICAgICAvKiBBIGRpc2NyZXBhbmN5IGhlcmUgaXMgdGhhdCB3ZSBkbyBu b3QgcmVwb3J0IHRoZSBzdGF0dXMgb2YKICAgICAgICAgICogbm9uLWk5MTUgZmVuY2VzLCBpLmUu IGV2ZW4gdGhvdWdoIHdlIG1heSByZXBvcnQgdGhlIG9iamVjdCBhcyBpZGxlLAogICAgICAgICAg KiBhIGNhbGwgdG8gc2V0LWRvbWFpbiBtYXkgc3RpbGwgc3RhbGwgd2FpdGluZyBmb3IgZm9yZWln biByZW5kZXJpbmcuCiAgICAgICAgICAqIFRoaXMgYWxzbyBtZWFucyB0aGF0IHdhaXQtaW9jdGwg bWF5IHJlcG9ydCBhbiBvYmplY3QgYXMgYnVzeSwKICAgICAgICAgICogd2hlcmUgYnVzeS1pb2N0 bCBjb25zaWRlcnMgaXQgaWRsZS4KICAgICAgICAgICoKICAgICAgICAgICogV2UgdHJhZGUgdGhl IGFiaWxpdHkgdG8gd2FybiBvZiBmb3JlaWduIGZlbmNlcyB0byByZXBvcnQgb24gd2hpY2gKICAg ICAgICAgICogaTkxNSBlbmdpbmVzIGFyZSBhY3RpdmUgZm9yIHRoZSBvYmplY3QuCiAgICAgICAg ICAqCiAgICAgICAgICAqIEFsdGVybmF0aXZlbHksIHdlIGNhbiB0cmFkZSB0aGF0IGV4dHJhIGlu Zm9ybWF0aW9uIG9uIHJlYWQvd3JpdGUKICAgICAgICAgICogYWN0aXZpdHkgd2l0aAogICAgICAg ICAgKiAgICAgYXJncy0+YnVzeSA9CiAgICAgICAgICAqICAgICAgICAgICAgICFyZXNlcnZhdGlv bl9vYmplY3RfdGVzdF9zaWduYWxlZF9yY3Uob2JqLT5yZXN2LCB0cnVlKTsKICAgICAgICAgICog dG8gcmVwb3J0IHRoZSBvdmVyYWxsIGJ1c3luZXNzLiBUaGlzIGlzIHdoYXQgdGhlIHdhaXQtaW9j dGwgZG9lcy4KICAgICAgICAgICovCiAgICAgICAgYXJncy0+YnVzeSA9IDA7CgogICAgICAgIC8q IFRyYW5zbGF0ZSBzaGFyZWQgZmVuY2VzIHRvIFJFQUQgc2V0IG9mIGVuZ2luZXMgKi8KICAgICAg ICBmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykgewogICAgICAgICAgICAgICAgYXJncy0+YnVz eSB8PSBidXN5X2NoZWNrX3JlYWRlcihzaGFyZWRbaV0pOwogICAgICAgICAgICAgICAgZmVuY2Vf cHV0KHNoYXJlZFtpXSk7CiAgICAgICAgfQogICAgICAgIGtmcmVlKHNoYXJlZCk7CgogICAgICAg IC8qIFRyYW5zbGF0ZSB0aGUgZXhjbHVzaXZlIGZlbmNlIHRvIHRoZSBSRUFEICphbmQqIFdSSVRF IGVuZ2luZSAqLwogICAgICAgIGlmIChleGNsKSB7CiAgICAgICAgICAgICAgICBhcmdzLT5idXN5 IHw9IGJ1c3lfY2hlY2tfd3JpdGVyKGV4Y2wpOwogICAgICAgICAgICAgICAgZmVuY2VfcHV0KGV4 Y2wpOwogICAgICAgIH0KCiAgICAgICAgcmV0dXJuIDA7Cn0KCi1DaHJpcwoKLS0gCkNocmlzIFdp bHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==