All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] perf/x86/amd: Make HW_CACHE_REFERENCES and HW_CACHE_MISSES measure L2
Date: Fri, 16 Sep 2016 14:01:19 +0100	[thread overview]
Message-ID: <20160916130119.GE16797@codeblueprint.co.uk> (raw)
In-Reply-To: <20160825033514.GA31573@nazgul.tnic>

On Thu, 25 Aug, at 05:35:14AM, Borislav Petkov wrote:
> (dropping stable@ from CC)
> 
> On Wed, Aug 24, 2016 at 08:27:06PM +0200, Peter Zijlstra wrote:
> > They're not meant to be comparable between machines. I wouldn't even
> > compare the LLC numbers between two different Intel parts.
> > 
> > These events are meant to profile a workload on the machine you run them
> > on. Big cache-miss/ref ratios indicate you loose performance because of
> > the memory subsystem and or data structure layout.
> 
> Ah ok, then I've misunderstood Matt's justification in the commit message.
> 
> FWIW: Acked-by: Borislav Petkov <bp@suse.de>

Ping? Tip folks: are you OK to apply this?

  reply	other threads:[~2016-09-16 13:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 13:12 [PATCH v2] perf/x86/amd: Make HW_CACHE_REFERENCES and HW_CACHE_MISSES measure L2 Matt Fleming
2016-08-24 14:55 ` Borislav Petkov
2016-08-24 18:27   ` Peter Zijlstra
2016-08-25  3:35     ` Borislav Petkov
2016-09-16 13:01       ` Matt Fleming [this message]
2016-09-16 16:09 ` [tip:perf/urgent] " tip-bot for Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916130119.GE16797@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.