From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933236AbcIPN4S (ORCPT ); Fri, 16 Sep 2016 09:56:18 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:51100 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756478AbcIPN4K (ORCPT ); Fri, 16 Sep 2016 09:56:10 -0400 Date: Fri, 16 Sep 2016 15:55:37 +0200 From: Ralf Baechle To: Baoyou Xie Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, akpm@linux-foundation.org, paul.burton@imgtec.com, chenhc@lemote.com, david.daney@cavium.com, kumba@gentoo.org, yamada.masahiro@socionext.com, kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com, toshi.kani@hpe.com, dan.j.williams@intel.com, luto@kernel.org, JBeulich@suse.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH v2] mm: move phys_mem_access_prot_allowed() declaration to pgtable.h Message-ID: <20160916135537.GA22042@linux-mips.org> References: <1473751597-12139-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473751597-12139-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2016 at 03:26:37PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/char/mem.c:220:12: warning: no previous prototype for 'phys_mem_access_prot_allowed' [-Wmissing-prototypes] > int __weak phys_mem_access_prot_allowed(struct file *file, > > In fact, its declaration is spreading to several header files > in different architecture, but need to be declare in common > header file. > > So this patch moves phys_mem_access_prot_allowed() to pgtable.h. > > Signed-off-by: Baoyou Xie Acked-by: Ralf Baechle Ralf