Re: [PATCH] Staging: iio: adc: Add space around '-'

[Katie Dunne <kdunne@mail.ccsf.edu>]

On Fri, Sep 16, 2016 at 08:08:51AM -0700, Katherine Dunne wrote:
> 
> 
> On Wednesday, September 14, 2016 at 4:01:57 AM UTC-7, Sandhya Bankar wrote:
> >
> > Add space around operator '-' . 
> > This patch is found by checkpatch.pl script . 
> > CHECK: spaces preferred around that '-' (ctx:VxV) . 

Hi Sandhya,

This is a false positive from checkpatch. To save you
some time here is the response from Jonathan:

"Just to explain a bit more.  Checkpatch is assuming that it is looking
at two parameters. It's not. That's a string being passed into the
macro.  It ultimately forms a file name in sysfs. 

p.s. We get patches for this from time to time ;(  Unfortunately
it's a somewhat obscure case for checkpatch."

Regards,
Katie

> > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/iio/adc/ad7192.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c 
> > b/drivers/staging/iio/adc/ad7192.c 
> > index 1cf6b79..5688b29 100644 
> > --- a/drivers/staging/iio/adc/ad7192.c 
> > +++ b/drivers/staging/iio/adc/ad7192.c 
> > @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev, 
> >  } 
> >   
> >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, 
> > -                             in_voltage-voltage_scale_available, 
> > +                             in_voltage - voltage_scale_available, 
> >                               S_IRUGO, ad7192_show_scale_available, NULL, 
> > 0); 
> >   
> >  static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, 
> > -- 
> > 1.8.2.3 
> >
> >