All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libfastjson: Was referencing non-existing files
Date: Fri, 16 Sep 2016 18:55:59 +0200	[thread overview]
Message-ID: <20160916185559.23a41621@free-electrons.com> (raw)
In-Reply-To: <1474018609-2610-1-git-send-email-fpa@sbtaqua.com>

Hello,

On Fri, 16 Sep 2016 11:36:49 +0200, Frederik Aalund wrote:

> -LIBFASTJSON_VERSION = v0.99.2
> +LIBFASTJSON_VERSION = 0.99.2
>  LIBFASTJSON_SITE = $(call github,rsyslog,libfastjson,$(LIBFASTJSON_VERSION))
> +LIBFASTJSON_SOURCE = v$(LIBFASTJSON_VERSION).tar.gz

This is not correct: the version is really v0.99.2, as this is the name
of the Git tag.

Moreover, I'm not sure what you're fixing here. It downloads perfectly
fine here without your patch:

>>> libfastjson v0.99.2 Downloading
--2016-09-16 18:53:29--  https://github.com/rsyslog/libfastjson/archive/v0.99.2/libfastjson-v0.99.2.tar.gz
Resolving github.com (github.com)... 192.30.253.113
Connecting to github.com (github.com)|192.30.253.113|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 [following]
--2016-09-16 18:53:36--  https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2
Resolving codeload.github.com (codeload.github.com)... 192.30.253.121
Connecting to codeload.github.com (codeload.github.com)|192.30.253.121|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ?/home/thomas/projets/buildroot/output/build/.libfastjson-v0.99.2.tar.gz.PKe11m/output?

     0K .......... .......... .......... .......... .......... 80,8K
    50K .......... .......... .......... .....                  118K=0,9s

2016-09-16 18:53:38 (92,9 KB/s) - ?/home/thomas/projets/buildroot/output/build/.libfastjson-v0.99.2.tar.gz.PKe11m/output? saved [87526]

libfastjson-v0.99.2.tar.gz: OK (sha256: fcdca0c4702362de3db3f02c8da05f985b54a9eccd618af41730409b75d10a8f)

Could you be more specific in the issue you were facing, such as
posting a build log of what happens during the download without your
patch applied?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-09-16 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  9:36 [Buildroot] [PATCH 1/1] libfastjson: Was referencing non-existing files Frederik Aalund
2016-09-16 16:55 ` Thomas Petazzoni [this message]
2016-09-20 13:36   ` Frederik Peter Aalund
2016-09-20 14:33     ` Peter Korsgaard
2016-09-21  8:44       ` Frederik Peter Aalund
2016-09-21  9:00         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916185559.23a41621@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.