All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Yadi Hu <yadi.hu@windriver.com>
Cc: jdelvare@suse.de, linux-i2c@vger.kernel.org
Subject: Re: RESEND:i2c-eg20t: fix race between i2c init and interrupt enable
Date: Fri, 16 Sep 2016 22:04:57 +0200	[thread overview]
Message-ID: <20160916200456.GA2216@katana> (raw)
In-Reply-To: <1473240337-5694-1-git-send-email-yadi.hu@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]


> after testing last patch, replacing request_irq() location is not a
> good idea,it might produce a little time windows ,in which the interrupts
> occurring inside  will be omitted.
> 
> the new patch adds a check point on interrupt handler in case field
> 'pch_base_address' has not been initialed.

What about using two for-loops in probe like this pseudo code?

for (all_channels)
	do_initialization

request_irq()

for (all_channels)
	register_adapter


This seems to me the correct order and most readable solution.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-09-16 20:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  9:25 RESEND:i2c-eg20t: fix race between i2c init and interrupt enable Yadi Hu
2016-09-07  9:25 ` [PATCH] i2c-eg20t: " Yadi Hu
2016-09-12  0:41 ` RESEND:i2c-eg20t: " Yadi
2016-09-14  6:39 ` Yadi
2016-09-14  7:28 ` Wolfram Sang
2016-09-14  7:49   ` Yadi
2016-09-16 20:04 ` Wolfram Sang [this message]
2016-09-18  2:55   ` Yadi
2016-09-18  7:53     ` Wolfram Sang
2016-09-18  8:51       ` Yadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916200456.GA2216@katana \
    --to=wsa@the-dreams.de \
    --cc=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=yadi.hu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.