From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] drivers: advertise kmod dependencies in pmdinfo Date: Mon, 19 Sep 2016 09:17:27 +0100 Message-ID: <20160919081726.GA23360@bricha3-MOBL3> References: <1472217646-26219-1-git-send-email-olivier.matz@6wind.com> <1473949355-6787-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Olivier Matz , Neil Horman , Thomas Monjalon , vido@cesnet.cz, fiona.trahe@intel.com, Stephen Hemminger , "dev@dpdk.org" To: David Marchand Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 24CEF29CF for ; Mon, 19 Sep 2016 10:17:31 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 16, 2016 at 04:26:35PM +0200, David Marchand wrote: > On Thu, Sep 15, 2016 at 4:22 PM, Olivier Matz wrote: > > Add a new macro DRIVER_REGISTER_KMOD_DEP() that allows a driver to > > declare the list of kernel modules required to run properly. > > > > Today, most PCI drivers require uio/vfio. > > > > Signed-off-by: Olivier Matz > > Thanks Olivier, this looks good to me. > > Btw, I remember some issues with binding ixgbevf devices to > uio_pci_generic, so advertising should be carefully checked for each > driver. +1 here. In general, uio_pci_generic will not bind to VF devices as VF devices don't provide legacy interrupts, which is required to use uio_pci_generic. It's not limited to just ixgbevf /Bruce