From: Chris Wilson <chris@chris-wilson.co.uk>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/18] drm/i915: Record space required for request emission
Date: Mon, 19 Sep 2016 12:32:32 +0100 [thread overview]
Message-ID: <20160919113232.GD16178@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1474282050.3344.19.camel@linux.intel.com>
On Mon, Sep 19, 2016 at 01:47:30PM +0300, Joonas Lahtinen wrote:
> On ke, 2016-09-14 at 07:52 +0100, Chris Wilson wrote:
> > @@ -2677,8 +2681,21 @@ static void intel_ring_default_vfuncs(struct drm_i915_private *dev_priv,
> > engine->reset_hw = reset_ring_common;
> >
> > engine->emit_request = i9xx_emit_request;
> > - if (i915.semaphores)
> > + engine->emit_request_sz = i9xx_emit_request_sz;
> > + if (i915.semaphores) {
> > + int num_rings;
>
> 'initialized_rings' to differentiate as suggested by Tvrtko too.
Tvrtko wasn't referring to this. The point is that we don't know
initialized_rings here, just the declared set of rings we think
the hardware is supposed to have.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-19 11:32 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 6:52 Tracking multiple timelines (full-ppgtt) Chris Wilson
2016-09-14 6:52 ` [PATCH 01/18] drm/i915: Support asynchronous waits on struct fence from i915_gem_request Chris Wilson
2016-09-14 7:37 ` Joonas Lahtinen
2016-09-19 11:26 ` Chris Wilson
2016-09-14 6:52 ` [PATCH 02/18] drm/i915: Allow i915_sw_fence_await_sw_fence() to allocate Chris Wilson
2016-09-14 7:51 ` Joonas Lahtinen
2016-09-14 8:46 ` Chris Wilson
2016-09-14 6:52 ` [PATCH 03/18] drm/i915: Rearrange i915_wait_request() accounting with callers Chris Wilson
2016-09-14 8:47 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 04/18] drm/i915: Remove unused i915_gem_active_wait() in favour of _unlocked() Chris Wilson
2016-09-14 8:48 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 05/18] drm/i915: Move GEM activity tracking into a common struct reservation_object Chris Wilson
2016-09-14 9:44 ` Joonas Lahtinen
2016-09-14 17:35 ` Chris Wilson
2016-09-15 9:38 ` Dave Gordon
2016-09-15 9:55 ` Jani Nikula
2016-09-16 11:40 ` Chris Wilson
2016-09-14 6:52 ` [PATCH 06/18] drm: Add reference counting to drm_atomic_state Chris Wilson
2016-09-14 6:52 ` [PATCH 07/18] drm/i915: Restore nonblocking awaits for modesetting Chris Wilson
2016-09-19 16:01 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 08/18] drm/i915: Combine seqno + tracking into a global timeline struct Chris Wilson
2016-09-14 15:42 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 09/18] drm/i915: Wait first for submission, before waiting for request completion Chris Wilson
2016-09-19 8:59 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 10/18] drm/i915: Introduce a global_seqno for each request Chris Wilson
2016-09-19 10:36 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 11/18] drm/i915: Record space required for request emission Chris Wilson
2016-09-14 13:30 ` Tvrtko Ursulin
2016-09-14 17:33 ` Chris Wilson
2016-09-15 8:59 ` Tvrtko Ursulin
2016-09-19 10:47 ` Joonas Lahtinen
2016-09-19 11:32 ` Chris Wilson [this message]
2016-09-19 16:09 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 12/18] drm/i915: Defer " Chris Wilson
2016-09-19 12:06 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 13/18] drm/i915: Move the global sync optimisation to the timeline Chris Wilson
2016-09-19 13:16 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 14/18] drm/i915: Create a unique name for the context Chris Wilson
2016-09-19 13:23 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 15/18] drm/i915: Reserve space in the global seqno during request allocation Chris Wilson
2016-09-19 13:47 ` Joonas Lahtinen
2016-09-19 15:35 ` Jani Nikula
2016-09-19 16:07 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 16/18] drm/i915: Enable multiple timelines Chris Wilson
2016-09-19 15:52 ` Joonas Lahtinen
2016-10-20 12:49 ` Chris Wilson
2016-10-20 15:25 ` Joonas Lahtinen
2016-09-14 6:52 ` [PATCH 17/18] drm/i915: Enable userspace to opt-out of implicit fencing Chris Wilson
2016-09-14 6:52 ` [PATCH 18/18] drm/i915: Support explicit fencing for execbuf Chris Wilson
2016-09-14 9:16 ` ✗ Fi.CI.BAT: failure for series starting with [01/18] drm/i915: Support asynchronous waits on struct fence from i915_gem_request Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919113232.GD16178@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.