From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols. Date: Mon, 19 Sep 2016 13:32:57 -0400 Message-ID: <20160919173249.GA32633@localhost.localdomain> References: <1474043908-12101-1-git-send-email-konrad.wilk@oracle.com> <1474043908-12101-8-git-send-email-konrad.wilk@oracle.com> <57DFCB84020000780010FE0D@prv-mh.provo.novell.com> <258a2a06-8c90-6e57-33e9-9afba04d87f7@arm.com> <57E00E1702000078001101C1@prv-mh.provo.novell.com> <57E016CA0200007800110251@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bm2Rv-0006N2-SZ for xen-devel@lists.xenproject.org; Mon, 19 Sep 2016 17:33:47 +0000 Content-Disposition: inline In-Reply-To: <57E016CA0200007800110251@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: sstabellini@kernel.org, ross.lagerwall@citrix.com, Andrew Cooper , Julien Grall , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBTZXAgMTksIDIwMTYgYXQgMDg6NDg6MTBBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDE5LjA5LjE2IGF0IDE2OjEzLCA8anVsaWVuLmdyYWxsQGFybS5jb20+IHdy b3RlOgo+IAo+ID4gCj4gPiBPbiAxOS8wOS8yMDE2IDE2OjExLCBKYW4gQmV1bGljaCB3cm90ZToK PiA+Pj4+PiBPbiAxOS4wOS4xNiBhdCAxNTozMywgPGp1bGllbi5ncmFsbEBhcm0uY29tPiB3cm90 ZToKPiA+Pj4gT24gMTkvMDkvMjAxNiAxMToyNywgSmFuIEJldWxpY2ggd3JvdGU6Cj4gPj4+Pj4+ PiBPbiAxNi4wOS4xNiBhdCAxODozOCwgPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+IHdyb3RlOgo+ ID4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9saXZlcGF0Y2guYwo+ID4+Pj4+ICsrKyBiL3hlbi9h cmNoL2FybS9saXZlcGF0Y2guYwo+ID4+Pj4+IEBAIC0xMTcsNiArMTE3LDIwIEBAIGJvb2wgYXJj aF9saXZlcGF0Y2hfc3ltYm9sX29rKGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZWxmCj4gPj4+ICpl bGYsCj4gPj4+Pj4gICAgICByZXR1cm4gdHJ1ZTsKPiA+Pj4+PiAgfQo+ID4+Pj4+Cj4gPj4+Pj4g K2Jvb2wgYXJjaF9saXZlcGF0Y2hfc3ltYm9sX2RlbnkoY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9l bGYgKmVsZiwKPiA+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBz dHJ1Y3QgbGl2ZXBhdGNoX2VsZl9zeW0gKnN5bSkKPiA+Pj4+PiArewo+ID4+Pj4+ICsjaWZkZWYg Q09ORklHX0FSTV8zMgo+ID4+Pj4+ICsgICAgLyoKPiA+Pj4+PiArICAgICAqIFhlbiBkb2VzIG5v dCB1c2UgVGh1bWIgaW5zdHJ1Y3Rpb25zIC0gYW5kIHdlIHNob3VsZCBub3Qgc2VlIGFueSBvZgo+ ID4+Pj4+ICsgICAgICogdGhlbS4gSWYgd2UgZG8sIGFib3J0Lgo+ID4+Pj4+ICsgICAgICovCj4g Pj4+Pj4gKyAgICBpZiAoIHN5bS0+bmFtZSAmJiAqc3ltLT5uYW1lID09ICckJyAmJiBzeW0tPm5h bWVbMV0gPT0gJ3QnICkKPiA+Pj4KPiA+Pj4gUGxlYXNlIHVzZSBzeW0tPm5hbWVbMF0gZm9yIHJl YWRhYmlsaXR5LiBBbHNvLCB5b3UgbWF5IHdhbnQgdG8gY2hlY2sgdGhlCj4gPj4+IGxlbmd0aCBv ZiB0aGUgc3ltYm9sIGJlZm9yZSBjaGVja2luZyB0aGUgc2Vjb25kIGNoYXJhY3Rlci4KPiA+Pgo+ ID4+IFdoeSB3b3VsZCB0aGUgbGVuZ3RoIGNoZWNrIGJlIG5lZWRlZD8gSWYgdGhlIGZpcnN0IGNo YXJhY3RlciBpcyAkLAo+ID4+IHRoZW4gbG9va2luZyBhdCB0aGUgc2Vjb25kIG9uZSBpcyBhbHdh eXMgdmFsaWQgKGFuZCBpdCBiZWluZyBudWwgd2lsbAo+ID4+IGJlIHByb3Blcmx5IGRlYWx0IHdp dGggYnkgdGhlIGV4cHJlc3Npb24gYWJvdmUpLgo+ID4gCj4gPiBCZWNhdXNlIHlvdSBtYXkgaGF2 ZSBhIHBheWxvYWQgd2hpY2ggaXMgbm90IHZhbGlkPyBPciBtYXliZSB5b3UgY29uc2lkZXIgCj4g PiB0aGF0IGFsbCB0aGUgcGF5bG9hZCBhcmUgdHJ1c3RlZC4KPiAKPiBJZiBhbGwgc3ltYm9scycg bmFtZXMgYXJlIGluc2lkZSB0aGVpciBzdHJpbmcgdGFibGVzIGFuZCB0aGUgc3RyaW5nCj4gdGFi bGVzIGFyZSBib3RoIGNvbnRhaW5lZCBpbnNpZGUgdGhlIGltYWdlIGFuZCBoYXZlIGEgemVybyBi eXRlCj4gYXQgdGhlaXIgZW5kIChhbGwgb2Ygd2hpY2ggZ2V0cyB2ZXJpZmllZCBhZmFpciksIG5v dGhpbmcgYmFkIGNhbgo+IGhhcHBlbiBJIHRoaW5rLgoKRXhhY3RseS4gQWxsIG9mIHRob3NlIGNo ZWNrcyBhcmUgZG9uZSBzbyB3ZSBhcmUgc3VyZSB0aGF0IHRoZQpzeW0tPm5hbWVbMF0gcG9pbnRz IHRvIHNvbWV0aGluZy4KCgpKdWxpZW4sIEkgY2FuIHVzZSBzdHJsZW4gaWYgeW91IHByZWZlciwg c28gaXQgd291bGQgYmUgbGlrZSBzbzoKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIApib29sIGFyY2hf bGl2ZXBhdGNoX3N5bWJvbF9kZW55KGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9lbGZf c3ltICpzeW0pCnsKI2lmZGVmIENPTkZJR19BUk1fMzIKICAgIC8qCiAgICAgKiBYZW4gZG9lcyBu b3QgdXNlIFRodW1iIGluc3RydWN0aW9ucyAtIGFuZCB3ZSBzaG91bGQgbm90IHNlZSBhbnkgb2YK ICAgICAqIHRoZW0uIElmIHdlIGRvLCBhYm9ydC4KICAgICAqLwogICAgaWYgKCBzeW0tbmFtZSAm JiBzeW0tPm5hbWVbMF0gPT0gJyQnICYmIHN5bS0+bmFtZVsxXSA9PSAndCcgKQogICAgewogICAg ICAgIHNpemVfdCBsZW4gPSBzdHJsZW4oc3ltLT5uYW1lKTsKCiAgICAgICAgaWYgKCAobGVuID49 IDMgJiYgKHN5bS0+bmFtZVsyXSA9PSAnLicpKSB8fCBsZW4gPT0gMiApCiAgICAgICAgICAgIHJl dHVybiB0cnVlOwogICAgfQojZW5kaWYKICAgIHJldHVybiBmYWxzZTsKfQoKT3IgdGhpcyB3YXk6 Cgpib29sIGFyY2hfbGl2ZXBhdGNoX3N5bWJvbF9kZW55KGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hf ZWxmICplbGYsICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZWxmX3N5bSAqc3ltKSAgICAgICAgICAgIAp7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIAojaWZkZWYgQ09ORklHX0FSTV8zMiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgLyogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIAogICAgICogWGVuIGRvZXMgbm90IHVzZSBUaHVtYiBpbnN0cnVjdGlvbnMgLSBhbmQg d2Ugc2hvdWxkIG5vdCBzZWUgYW55CiAgICAgKiBvZiAgICAgICAgICAKICAgICAqIHRoZW0uIElm IHdlIGRvLCBhYm9ydC4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAKICAgICAqLyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgIGlmICggc3ltLT5uYW1lICYmIHN5 bS0+bmFtZVswXSA9PSAnJCcgJiYgc3ltLT5uYW1lWzFdID09ICd0JyApICAgICAgICAgICAgICAg ICAgICAgICAgICAgCiAgICB7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgaWYgKCBzeW0tPm5h bWVbMl0gJiYgc3ltLT5uYW1lWzJdICE9ICcuJyApICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCiAgICAgICAgICAgIHJldHVybiBmYWxzZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAg ICAgcmV0dXJuIHRydWU7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgCiAgICB9ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiNlbmRpZiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgCiAgICByZXR1cm4gZmFsc2U7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCn0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAoKCkJvdGggYWRkIGV4YWN0bHkgdGhlIHNhbWUgYW1vdW50IG9mIGxpbmVz IG9mIGNvZGUgOi0pCgo+IAo+IEphbgo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==