From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932885AbcISUBJ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 16:01:09 -0400
Received: from mail-lf0-f66.google.com ([209.85.215.66]:34586 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932797AbcISUBD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 16:01:03 -0400
Date: Mon, 19 Sep 2016 22:00:55 +0200
From: Rabin Vincent <rabin@rab.in>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>,
        Vince Weaver <vincent.weaver@maine.edu>,
        LKML <linux-kernel@vger.kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
        Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: [PATCH v3] scripts: add script for translating stack dump
 function
Message-ID: <20160919200055.GA17411@lnxartpec.se.axis.com>
References: <CA+55aFwa4so_H-yjgzV5gU1OyCapU7=-hY5LTcMFHfgqsPuXeQ@mail.gmail.com>
 <20160916191738.v3kq3c44zmdsvlgb@treble>
 <CA+55aFz_=-WQMZ3exuSEzNUzdB_ica8VZtCbf3wsj1XGFOTS+w@mail.gmail.com>
 <20160916212656.bnmxrl3cglsbjmpm@treble>
 <CA+55aFyUL1brPvMHrGv8qQ4HzyOsE27J_X55ZSRkRZp+p_pcgg@mail.gmail.com>
 <20160917004212.tsr3taygbcidvgl5@treble>
 <CA+55aFxo-kcYsMg5oF_YNxGH8ydm2p+=K885k6+YWzMxHniFFg@mail.gmail.com>
 <20160919155214.ap2cgwjkjn2s7itr@treble>
 <CA+55aFy=doUjoJh7fKpevV-JvEYjvfV5ZdQav+yiFBwygZ-Pag@mail.gmail.com>
 <CA+55aFxekTpeBPA1cwTYHOSErLStH4_H7jyh0KsuH1upRvuQ7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+55aFxekTpeBPA1cwTYHOSErLStH4_H7jyh0KsuH1upRvuQ7g@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote:
> Hmm. Would you mind if I change the
> 
>         addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;"
> 
> into
> 
>         addr2line -fpie $objfile $hexaddr |
>                 sed "s; at $dir_prefix\(\./\)*; at ;"
> 
> instead? There's two changes there: matching the " at " part (to just
> make the match stricter) but also matching any following "./" thing
> (which shows up for our include tree files, at least for me).

Note that addr2line has localized strings, so the regex with the " at "
won't match for everyone unless you invoke addr2line with LANG=C.

$ ../linux/scripts/faddr2line vmlinux free_reserved_area+61
free_reserved_area+61/0xe4:
__write_once_size på /home/rabinv/dev/linux/include/linux/compiler.h:248
(inline:ad av)set_page_count på /home/rabinv/dev/linux/include/linux/page_ref.h:76
(inline:ad av)init_page_count på /home/rabinv/dev/linux/include/linux/page_ref.h:87
(inline:ad av)__free_reserved_page på /home/rabinv/dev/linux/include/linux/mm.h:1818
(inline:ad av)free_reserved_page på /home/rabinv/dev/linux/include/linux/mm.h:1824
(inline:ad av)free_reserved_area på /home/rabinv/dev/linux/mm/page_alloc.c:6476

$ LANG=C ../linux/scripts/faddr2line vmlinux free_reserved_area+61
free_reserved_area+61/0xe4:
__write_once_size at include/linux/compiler.h:248
 (inlined by) set_page_count at include/linux/page_ref.h:76
 (inlined by) init_page_count at include/linux/page_ref.h:87
 (inlined by) __free_reserved_page at include/linux/mm.h:1818
 (inlined by) free_reserved_page at include/linux/mm.h:1824
 (inlined by) free_reserved_area at mm/page_alloc.c:6476