From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmELP-0006rj-3Z for qemu-devel@nongnu.org; Tue, 20 Sep 2016 02:15:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmELK-00006X-Vt for qemu-devel@nongnu.org; Tue, 20 Sep 2016 02:15:50 -0400 Received: from ozlabs.org ([103.22.144.67]:33704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmELK-0008VW-93 for qemu-devel@nongnu.org; Tue, 20 Sep 2016 02:15:46 -0400 Date: Tue, 20 Sep 2016 16:14:59 +1000 From: David Gibson Message-ID: <20160920061459.GY20488@umbus> References: <1473841548-26742-1-git-send-email-peterx@redhat.com> <29444a1f-4e4d-e2fc-0142-8674c0160286@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cx6gHIjlhIvUM2fk" Content-Disposition: inline In-Reply-To: <29444a1f-4e4d-e2fc-0142-8674c0160286@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 0/3] Introduce IOMMUNotifier struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Xu , qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com, vkaplans@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, cornelia.huck@de.ibm.com, dgibson@redhat.com --Cx6gHIjlhIvUM2fk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 19, 2016 at 02:47:40PM +0200, Paolo Bonzini wrote: >=20 >=20 > On 14/09/2016 10:25, Peter Xu wrote: > > (Note: we still have pending discussions on how IOMMU notifier > > interface should be, assuming that is not a blocker for posting v5 of > > this one) > >=20 > > V5: > > - squash spapr_tce_notify_{started|stopped} into > > spapr_tce_notify_flag_changed [David] > > - in spapr_tce_notify_flag_changed: check flags against "!=3D > > IOMMU_NOTIFIER_NONE", but not "=3D=3D IOMMU_NOTIFIER_ALL" [David] > > - add r-b for David on patch 3 >=20 > Looks good, thanks. >=20 > If David doesn't reply further I'll merge this. Sorry, I've been caught up downstream, and didn't have a look at this. I still have some comments. >=20 > Paolo >=20 > > V4: > > - change "notifier_caps" into "notifier_flags" [David] > > - rename IOMMU_NOTIFIER_{CHANGE|INVALIDATION} with MAP/UNMAP [David] > > - introduce IOMMUOps.notify_flag_changed, to replace notify_started > > and notify_stopped [David, Paolo] > >=20 > > V3: > > - use QLIST instead of embedding Notifier into IOMMUNotifier [Paolo] > > - fix a build error for ppc64-softmmu > >=20 > > The idea originates from one of Alex's reply: > >=20 > > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg00254.html > >=20 > > But after further discussions, it seems that only adding a simple type > > for notifier is not enough. This series introduced IOMMUNotifier > > struct to replace the old Notifier interface. Along with it, we can > > provide registration for one (or multiple) of the IOMMU notifications: > >=20 > > - cache invalidations > > - entry changes > >=20 > > This is a support material for Jason's vhost dmar patchset. > >=20 > > Please read commit messages for detailed information. Thanks, > >=20 > > Peter Xu (3): > > memory: introduce IOMMUNotifier and its caps > > memory: introduce IOMMUOps.notify_flag_changed > > intel_iommu: allow UNMAP notifiers > >=20 > > hw/i386/intel_iommu.c | 18 ++++++++----- > > hw/ppc/spapr_iommu.c | 18 +++++++------ > > hw/vfio/common.c | 3 ++- > > include/exec/memory.h | 47 +++++++++++++++++++++++++-------- > > include/hw/vfio/vfio-common.h | 2 +- > > memory.c | 60 +++++++++++++++++++++++++++++++++--= -------- > > 6 files changed, 107 insertions(+), 41 deletions(-) > >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Cx6gHIjlhIvUM2fk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX4NPjAAoJEGw4ysog2bOSA0YQAK7UCvk8Fk35YFNxJoSGrXNy XteMzwVWjAa2zEOgVLCqLFJbv+tyeHPi4jA+Yeo5rKEpARQrO/Gk5/nO7g4MRaln lCtLctVmGlC75KLJLa4ASWwksA4LSHowQ9YXesfXDqw7LSaSTyD3XosmsqtCeulk X2tOKh9gtVcGN1oGL+6L7fC4hT4otTphK/hbq3hHWfKs/tYHTQwLkOLVE9XFkR2h Z0mqrkBDaOvXVQFI4aPKBWquxphpM0CJV9P03FDy5P+sjykkW+5MEjKNm6sNx+dv 3G5mfjMlskUkuvLYDn8fPfUObWY1nQiYEGaOd91cUYaaOjU/QmfycPcslAJmQ7Zn 9iow/EHPOLUsT0PBPLAkVXTnzzvKYfeadi6c+ZB5Szi2pd+XGKs8iMIe4v/aLvtA dhABNyoEwJL7N6r0dync96Scs3QjkC+Qw45fu2/5PAZ9huoaSH8D7QDmFYxcxZGc gcHZkhKUKWoxcbLMhPW2dHV+4bqLbVD9VgpNity1sNI+R5Qavu3TXOT7+lpHpbrw O5cDh0IwvlblK+J+hKPMbtJd5y3Ik+7twXF0Ik9QY8et/949D7Aowk74yoDHonc5 LPndE/kBWeKcLLP2++0XIyX8fNnSwwVuhs+av8O38eZz3/s5+W7g/0B7OkR/IM7R p81ho+tbgCyiqSJse2Cm =DROJ -----END PGP SIGNATURE----- --Cx6gHIjlhIvUM2fk--