From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755610AbcITQJE (ORCPT ); Tue, 20 Sep 2016 12:09:04 -0400 Received: from mail.skyhub.de ([78.46.96.112]:45118 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755439AbcITQJA (ORCPT ); Tue, 20 Sep 2016 12:09:00 -0400 Date: Tue, 20 Sep 2016 18:08:55 +0200 From: Borislav Petkov To: bigeasy@linutronix.de, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:smp/hotplug] cpufreq: Fix up conversion to hotplug state machine Message-ID: <20160920160855.mut42gsbm5m5y2o5@pd.tnic> References: <20160920145628.lp2bmq72ip3oiash@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2016 at 08:07:08AM -0700, tip-bot for Sebastian Andrzej Siewior wrote: > Commit-ID: 5372e054a1928fe704cf0a5e2e139645a777b50a > Gitweb: http://git.kernel.org/tip/5372e054a1928fe704cf0a5e2e139645a777b50a > Author: Sebastian Andrzej Siewior > AuthorDate: Tue, 20 Sep 2016 16:56:28 +0200 > Committer: Thomas Gleixner > CommitDate: Tue, 20 Sep 2016 16:59:21 +0200 > > cpufreq: Fix up conversion to hotplug state machine > > The function cpufreq_register_driver() returns zero on success and since > commit 27622b061eb4 ("cpufreq: Convert to hotplug state machine") > erroneously a positive number. Due to the "if (x) assume_error" construct > all callers assumed an error and as a consequence the cpu freq kworker > crashes with a NULL pointer dereference. > > Reset the return value back to zero in the success case. > > Fixes: 27622b061eb4 ("cpufreq: Convert to hotplug state machine") > Reported-by: Borislav Petkov -and-tested-by: me. Thanks! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.