From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmOC1-0000mS-DD
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 12:46:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmOBw-0001QO-NG
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 12:46:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35036)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmOBw-0001QK-HR
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 12:46:44 -0400
Date: Tue, 20 Sep 2016 17:46:39 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160920164639.GE3012@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <20160919153600.70599974@t450s.home>
	<8e7e7357-cad4-f9ca-4104-97cadd347a13@redhat.com>
	<20160919162521.3569caa2@t450s.home>
	<32b91537-0d83-a312-db19-7341650c3d4a@nvidia.com>
	<20160920144152.GS25490@redhat.com>
	<3426a530-6741-e567-56d7-735bd5c98b54@redhat.com>
	<20160920145808.GT25490@redhat.com>
	<9e80c4e6-a94f-0fb3-7d57-9ac8ffe53738@redhat.com>
	<20160920151445.GU25490@redhat.com>
	<ce542157-843a-894d-8724-77c6b56806ed@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ce542157-843a-894d-8724-77c6b56806ed@nvidia.com>
Subject: Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Andy Currid <ACurrid@nvidia.com>, "Tian, Kevin" <kevin.tian@intel.com>, Neo Jia <cjia@nvidia.com>, "libvir-list@redhat.com" <libvir-list@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, "Song, Jike" <jike.song@intel.com>, Gerd Hoffmann <kraxel@redhat.com>, "bjsdjshi@linux.vnet.ibm.com" <bjsdjshi@linux.vnet.ibm.com>

On Tue, Sep 20, 2016 at 10:01:18PM +0530, Kirti Wankhede wrote:
> 
> 
> On 9/20/2016 8:44 PM, Daniel P. Berrange wrote:
> > On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote:
> >>
> >>
> >> On 20/09/2016 16:58, Daniel P. Berrange wrote:
> >>>>> As I've said in my earlier reply - libvirt will *NOT* support passing
> >>>>> arbitrary vendor specific parameters as a blob via the XML. Everything
> >>>>> that appears in the XML must be *fully* specified and explicitly
> >>>>> represented in the XML  as a distinct attribute or element.
> >>>>
> >>>> Are generic key/value attributes (e.g. a <attribute> element) acceptable?
> >>>
> >>> Only if libvirt has a known list of valid attribute key names upfront.
> >>> We don't want to just blindly expose arbitary vendor specific keys exposed
> >>> by the kernel. Libvirt's job is to ensure the XML representation is vendor
> >>> portable
> >>
> 
> In key/value attributes (taking example from proposed xml file)
> 
> <attribute name='resolution'>2560x1600</attribute>
> 
> 'Key' (i.e. 'resolution') should be known upfront, not the value, right?

NB, resolution is a good example of why we would *not* use the
generic <attribute name='$key'>$value</attribute> format in
the XML. Instead we'd represent it as

   <resolution width='2560' height='1600'/>

as applications should not have to further parse data after extracting
it from an XML attribute/element.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|