From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method Date: Tue, 20 Sep 2016 18:14:48 +0300 Message-ID: <20160920181358-mutt-send-email-mst@kernel.org> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-2-git-send-email-guangrong.xiao@linux.intel.com> <20160920160757.3fdc2ce8@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Xiao Guangrong , pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Igor Mammedov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbcITPOv (ORCPT ); Tue, 20 Sep 2016 11:14:51 -0400 Content-Disposition: inline In-Reply-To: <20160920160757.3fdc2ce8@nial.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Sep 20, 2016 at 04:07:57PM +0200, Igor Mammedov wrote: > As sanity check I'd suggest to extract nvdimm ssdt in guest, decompile and compile it back. > Currently I can't compile it back which mean it's really broken. Not always true, disassembler is sometimes producing weird code. But it's a strong hint. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmMl5-0004Ho-V7 for qemu-devel@nongnu.org; Tue, 20 Sep 2016 11:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmMl1-0001T8-FT for qemu-devel@nongnu.org; Tue, 20 Sep 2016 11:14:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmMl1-0001S0-9U for qemu-devel@nongnu.org; Tue, 20 Sep 2016 11:14:51 -0400 Date: Tue, 20 Sep 2016 18:14:48 +0300 From: "Michael S. Tsirkin" Message-ID: <20160920181358-mutt-send-email-mst@kernel.org> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-2-git-send-email-guangrong.xiao@linux.intel.com> <20160920160757.3fdc2ce8@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160920160757.3fdc2ce8@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Xiao Guangrong , pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On Tue, Sep 20, 2016 at 04:07:57PM +0200, Igor Mammedov wrote: > As sanity check I'd suggest to extract nvdimm ssdt in guest, decompile and compile it back. > Currently I can't compile it back which mean it's really broken. Not always true, disassembler is sometimes producing weird code. But it's a strong hint. -- MST