From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmZGz-0001PV-Jt for qemu-devel@nongnu.org; Wed, 21 Sep 2016 00:36:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmZGv-0004JT-CH for qemu-devel@nongnu.org; Wed, 21 Sep 2016 00:36:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmZGv-0004JI-6C for qemu-devel@nongnu.org; Wed, 21 Sep 2016 00:36:37 -0400 Date: Tue, 20 Sep 2016 22:36:35 -0600 From: Alex Williamson Message-ID: <20160920223635.1b457629@t450s.home> In-Reply-To: References: <00d96f24-5df0-d16b-d4e1-838333989dee@nvidia.com> <20160919153600.70599974@t450s.home> <3ae29391-5883-eb0c-5e93-3f93ef1bb143@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Tian, Kevin" Cc: Kirti Wankhede , "libvir-list@redhat.com" , qemu-devel , Paolo Bonzini , Neo Jia , Andy Currid , "Song, Jike" , "bjsdjshi@linux.vnet.ibm.com" , Gerd Hoffmann On Wed, 21 Sep 2016 03:56:21 +0000 "Tian, Kevin" wrote: > > From: Kirti Wankhede [mailto:kwankhede@nvidia.com] > > Sent: Tuesday, September 20, 2016 10:22 PM > > >> > > >> 'max_instance': > > >> Read-Only file. Mandatory. > > >> Returns integer. Returns maximum mdev device could be created > > >> at the moment when this file is read. This count would be updated by > > >> vendor driver. Before creating mdev device of this type, check if > > >> max_instance is > 0. > > > > > > Didn't we discuss this being being something like "available_instances" > > > with a "devices" sub-directory linking current devices of that type? > > > > > > > I'm ok with 'available_instances' as name of this file. > > Yes, mdev device directory will have links to devices of that type. I > > think that is part of mdev core module discussion. I'm trying to list > > sysfs files for libvirt interface here to focus more on libvirt > > interface. Hence didn't add that. I'll make sure to add all such details > > in future. > > > > > > Definitely you need provide those details since they also contain > libvirt interface, e.g. 'destroy' which we discussed should be in > mdev directory. $ find /sys/devices -name remove | wc -l 24 $ find /sys/devices -name destroy | wc -l 0 'remove' is the sysfs deconstructor we should use. > Another example is class-specific attributes such > as 'resolution', etc. which you listed under 'display class'. All those > attributes should be moved to mdev directory. Only class ID is > required under each type. Can you elaborate on what you're proposing here? If we don't have attributes like 'resolution' under the type-id then we can't describe to the user the features of the mdev before we create it. I don't think anybody wants a 'create it and find out' type of interface. Thanks, Alex