From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmYXG-0003H7-8O for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:49:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmYXB-0008Qz-9W for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:49:25 -0400 Received: from ozlabs.org ([103.22.144.67]:56492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmYXA-0008Qj-Se for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:49:21 -0400 Date: Wed, 21 Sep 2016 13:49:10 +1000 From: David Gibson Message-ID: <20160921034910.GX20488@umbus> References: <1473841548-26742-1-git-send-email-peterx@redhat.com> <1473841548-26742-4-git-send-email-peterx@redhat.com> <20160920061409.GX20488@umbus> <20160920072808.GE5134@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0qM52Bf5N6p3YITT" Content-Disposition: inline In-Reply-To: <20160920072808.GE5134@pxdev.xzpeter.org> Subject: Re: [Qemu-devel] [PATCH v5 3/3] intel_iommu: allow UNMAP notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com, vkaplans@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, dgibson@redhat.com --0qM52Bf5N6p3YITT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 20, 2016 at 03:28:08PM +0800, Peter Xu wrote: > On Tue, Sep 20, 2016 at 04:14:09PM +1000, David Gibson wrote: > > On Wed, Sep 14, 2016 at 04:25:48PM +0800, Peter Xu wrote: > > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > > Before that is achieved, let's open a door for vhost DMAR support, wh= ich > > > only requires cache invalidations (UNMAP operations). > > >=20 > > > Meanwhile, converting hw_error() to error_report() and exit(1), to ma= ke > > > the error messages clean and obvious (so no CPU registers will be > > > dumped). > >=20 > > Erm... AIUI currently the intel iommu driver doesn't do any > > notifications. Surely it's only valid to allow this once you've > > implemented unmap side notifications. >=20 > Yes, I suppose vhost DMAR patches will be based upon this one. I can > postpone this patch until Jason wants to pick it up, but it actually > does not hurt if we just enable it now, anyway no one is using it. Even so, I think it's misleading to implicitly advertise a capability that's not yet implemented. Changing this warning should happen after or at the same time as implementing the notifications in the vIOMMU model. > So... I see no bad to merge this along with the series, so that we can > reduce one entry from Jason's TODO list. :) >=20 > Thanks! >=20 > -- peterx >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --0qM52Bf5N6p3YITT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX4gM1AAoJEGw4ysog2bOS4l0QAJoPFEw1vEgso8iuxXrN+QMv oSVaEWJf4RqkMUhznT6jGx9knEvBac4f2NgWaao505+jXwkPv4MWGXpnrJeq791h Kbm6GZQHmnaYrZniiLzlR7G5MGGbIPs6uh/PrdSot+YXilgvCYdWu51L28Wfcfyx 4qD30YHDeE+wUjot27Dylxxi+qon7ZwZPC2CXvEASK+VvZBqB+6cZNHESsftxvB4 eECDNwlw/7c8T2vaIqWwVWdEX23DIfN1XFvUecUlnlizum6w7/iMsVpp/wDPI9FM xkvazNr5pXlR1aw74MH2k88IP1zzGeGtsjRbaG8vekrHXY6UoReZttVC5y+qKDGT Zyh558e5BscjCGv+VN6MsjsHUMHUWpjL5lKM+xm0DfCAcSHjbiAYSEygFQFMAPzU CpTr/Gv9fwJMjTyhlMUjA0OalQZ9rTIQtJMjPuAEWPQfPy+8gfS/IYzc5T03KeM1 JT/BAXcjI58cDdUVyh2Uh34bjCdAYO3Pqe9Z95HoQe/EGnEWrySMHAjy5O4CGGMM ohjRGX1mSIDZ0cnJ+FKoJ/kpLzlv2az3u0Lel2nd1dlXEzOIItM1S6nzWCJHO8Py QJSmVyG8jfL5p+3svwzP5/u/ehhl4HNZ8gCOqdbZS05iVc+fc6MkCKeDn25uDJh9 4w/gXuF/ytxrAJjJHTsG =aWf8 -----END PGP SIGNATURE----- --0qM52Bf5N6p3YITT--