From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755660AbcIUIDb (ORCPT ); Wed, 21 Sep 2016 04:03:31 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53137 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752172AbcIUIDX (ORCPT ); Wed, 21 Sep 2016 04:03:23 -0400 Date: Wed, 21 Sep 2016 10:03:10 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Nicolas Ferre , Boris Brezillon , Michael Turquette , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Message-ID: <20160921080310.szxig3mzebq2oseo@piout.net> References: <20160920205833.19638-1-alexandre.belloni@free-electrons.com> <20160920205833.19638-2-alexandre.belloni@free-electrons.com> <20160921000211.GH8319@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160921000211.GH8319@codeaurora.org> User-Agent: NeoMutt/20160910 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2016 at 17:02:11 -0700, Stephen Boyd wrote : > On 09/20, Alexandre Belloni wrote: > > Move all clocks related to the slow clock controller to sckc.c. This avoids > > extern definitions and allows to remove sckc.h > > > > Signed-off-by: Alexandre Belloni > > --- > > Applied to clk-next > Thanks for the fix! > drivers/clk/at91/sckc.c:146:13: > warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:260:13: > warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:359:13: > warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. > Should it be static? > > ----8<---- > diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c > index f6ed711af738..311956abf4aa 100644 > --- a/drivers/clk/at91/sckc.c > +++ b/drivers/clk/at91/sckc.c > @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_name; > @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > u32 frequency = 0; > @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_names[2]; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Wed, 21 Sep 2016 10:03:10 +0200 Subject: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c In-Reply-To: <20160921000211.GH8319@codeaurora.org> References: <20160920205833.19638-1-alexandre.belloni@free-electrons.com> <20160920205833.19638-2-alexandre.belloni@free-electrons.com> <20160921000211.GH8319@codeaurora.org> Message-ID: <20160921080310.szxig3mzebq2oseo@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20/09/2016 at 17:02:11 -0700, Stephen Boyd wrote : > On 09/20, Alexandre Belloni wrote: > > Move all clocks related to the slow clock controller to sckc.c. This avoids > > extern definitions and allows to remove sckc.h > > > > Signed-off-by: Alexandre Belloni > > --- > > Applied to clk-next > Thanks for the fix! > drivers/clk/at91/sckc.c:146:13: > warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:260:13: > warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not > declared. Should it be static? > drivers/clk/at91/sckc.c:359:13: > warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. > Should it be static? > > ----8<---- > diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c > index f6ed711af738..311956abf4aa 100644 > --- a/drivers/clk/at91/sckc.c > +++ b/drivers/clk/at91/sckc.c > @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_name; > @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > u32 frequency = 0; > @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, > return hw; > } > > -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, > - void __iomem *sckcr) > +static void __init > +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) > { > struct clk_hw *hw; > const char *parent_names[2]; > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com