From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH v2 0/2] x86: apic: add LVTT test Date: Wed, 21 Sep 2016 10:12:51 +0200 Message-ID: <20160921081251.4hngwcf2crzlvu3c@hawk.localdomain> References: <1474434582-21431-1-git-send-email-peterx@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com To: Peter Xu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548AbcIUINQ (ORCPT ); Wed, 21 Sep 2016 04:13:16 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A5AAC0567B2 for ; Wed, 21 Sep 2016 08:12:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1474434582-21431-1-git-send-email-peterx@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Sep 21, 2016 at 01:09:40PM +0800, Peter Xu wrote: > 1st patch fixes not eoi()ing in existing deadline timer isr. > > 2nd patch adds lvtt test. Please review. Thanks! > > v2 > - adding eoi() in LVT timer handler, otherwise continuous interrupt > will be ignored (found this when testing together with deadline > timer) > - better comments for "initial" [Drew] > - check lvtt_counter==1 in report() [Drew] > - setting x86/apic timeout to 30s [Drew] > > Peter Xu (2): > x86: apic: eoi() for deadline timer isr > x86: apic: add LVT timer test > > x86/apic.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > x86/unittests.cfg | 1 + > 2 files changed, 45 insertions(+) > > -- > 2.7.4 Both patches look good to me. Thanks, drew