From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmd2j-0001jI-M6 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmd2f-0002Vc-87 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:38:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmd2f-0002VL-1s for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:38:09 -0400 Date: Wed, 21 Sep 2016 09:38:05 +0100 From: "Daniel P. Berrange" Message-ID: <20160921083805.GC15535@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474429768-25027-1-git-send-email-famz@redhat.com> <1474429768-25027-3-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1474429768-25027-3-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/9] docker: Generate /packages.txt in fedora image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= On Wed, Sep 21, 2016 at 11:49:21AM +0800, Fam Zheng wrote: > Put the list of package names in an environment, and output their > package names to the target file in the end. > > Signed-off-by: Fam Zheng > --- > tests/docker/dockerfiles/fedora.docker | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker > index 1d26a8e..b414e88 100644 > --- a/tests/docker/dockerfiles/fedora.docker > +++ b/tests/docker/dockerfiles/fedora.docker > @@ -1,7 +1,17 @@ > FROM fedora:23 > -RUN dnf install -y \ > +ENV PACKAGES \ > ccache git tar PyYAML sparse flex bison \ > glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \ > gcc gcc-c++ clang make perl which bc findutils \ > - mingw{32,64}-{pixman,glib2,gmp,SDL,pkg-config,gtk2,gtk3,gnutls,nettle,libtasn1,libjpeg-turbo,libpng,curl,libssh2,bzip2} > + mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \ > + mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle mingw32-libtasn1 \ > + mingw32-libjpeg-turbo mingw32-libpng mingw32-curl mingw32-libssh2 \ > + mingw32-bzip2 \ > + mingw64-pixman mingw64-glib2 mingw64-gmp mingw64-SDL mingw64-pkg-config \ > + mingw64-gtk2 mingw64-gtk3 mingw64-gnutls mingw64-nettle mingw64-libtasn1 \ > + mingw64-libjpeg-turbo mingw64-libpng mingw64-curl mingw64-libssh2 \ > + mingw64-bzip2 > + > +RUN dnf install -y $PACKAGES > +RUN rpm -q $PACKAGES | sort > /packages.txt > ENV FEATURES mingw clang pyyaml Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|