From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56173)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd5x-00043s-2A
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:41:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd5v-0003Gw-T7
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:41:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56148)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd5v-0003Gk-MY
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:41:31 -0400
Date: Wed, 21 Sep 2016 09:41:26 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160921084126.GG15535@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1474429768-25027-1-git-send-email-famz@redhat.com>
	<1474429768-25027-7-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1474429768-25027-7-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/9] docker: Print used options before
 doing configure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>

On Wed, Sep 21, 2016 at 11:49:25AM +0800, Fam Zheng wrote:
> This makes the configure command more obvious which usually has useful
> information.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/common.rc | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 0c6d8d5..510a3ad 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -23,11 +23,13 @@ requires()
>  
>  build_qemu()
>  {
> -    $QEMU_SRC/configure \
> -        --enable-werror \
> -        ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
> -        --prefix="$PWD/install" \
> -        $EXTRA_CONFIGURE_OPTS \
> -        "$@"
> +    config_opts="--enable-werror \
> +                 ${TARGET_LIST:+--target-list=${TARGET_LIST}} \
> +                 --prefix=$PWD/install \
> +                 $EXTRA_CONFIGURE_OPTS \
> +                 $@"
> +    echo "Configure options:"
> +    echo $config_opts
> +    $QEMU_SRC/configure $config_opts
>      make $MAKEFLAGS
>  }

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|