From: David Sterba <dsterba@suse.cz>
To: jeffm@suse.com
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 0/5] btrfs: printing cleanup patchset
Date: Wed, 21 Sep 2016 17:46:09 +0200 [thread overview]
Message-ID: <20160921154609.GL16983@twin.jikos.cz> (raw)
In-Reply-To: <1474380303-25995-1-git-send-email-jeffm@suse.com>
On Tue, Sep 20, 2016 at 10:04:58AM -0400, jeffm@suse.com wrote:
> From: Jeff Mahoney <jeffm@suse.com>
>
> This is a patchset I've been working on to clean up message printing,
> make it adhere to kernel style, and be more consistent.
>
> The end result is that we:
> * use dynamic debugging for debugging messages
> * merge strings that exceed 80 characters into a single greppable string
> * convert printk calls to btrfs_{warn,info,err,debug,etc} calls where it
> makes sense.
> * dump the ad-hoc verbose_printk garbage in send
>
> The exception to this is check-integrity since it has a ton of messages
> and it also has its own mask mechanism. I wanted to discuss if we wanted
> to find another solution to that and, if so, how we want to move forward
> there.
IIRC integrity checker does a lot of custom string formatting,
indentation etc, but as it's a debugging feature you can leave it as is.
> Dave, this will probably conflict with the fsinfo patchset, so please
> advise on which you want to land first.
I've test-applied the whole patchset on current "for 4.9" queue and
there were no conflicts, so I that as a good starting point. Please use
the branch misc-4.9 for base of the fs_info cleanup patches. Thanks.
next prev parent reply other threads:[~2016-09-21 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 14:04 [PATCH 0/5] btrfs: printing cleanup patchset jeffm
2016-09-20 14:04 ` [PATCH 1/5] btrfs: add dynamic debug support jeffm
2016-09-20 14:05 ` [PATCH 2/5] btrfs: unsplit printed strings jeffm
2016-09-20 14:05 ` [PATCH 3/5] btrfs: convert printk(KERN_* to use pr_* calls jeffm
2016-09-20 14:05 ` [PATCH 4/5] btrfs: convert pr_* to btrfs_* where possible jeffm
2016-09-21 15:36 ` David Sterba
2016-09-23 12:37 ` David Sterba
2016-09-20 14:05 ` [PATCH 5/5] btrfs: convert send's verbose_printk to btrfs_debug jeffm
2016-09-21 15:43 ` [PATCH] btrfs: silence compiler warning when fs_info is not used David Sterba
2016-09-21 15:47 ` Jeff Mahoney
2016-09-21 16:16 ` Jeff Mahoney
2016-09-21 15:46 ` David Sterba [this message]
2016-09-21 16:17 ` [PATCH] btrfs: btrfs_debug should consume fs_info when DEBUG is not defined Jeff Mahoney
2016-09-22 14:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921154609.GL16983@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.