Hi Nicholas, [auto build test ERROR on asm-generic/master] [also build test ERROR on v4.8-rc7 next-20160920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/percpu-improve-generic-percpu-modify-return-implementation/20160921-170016 base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master config: blackfin-BF561-EZKIT-SMP_defconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=blackfin All error/warnings (new ones prefixed by >>): mm/vmstat.c: In function 'refresh_cpu_vm_stats': >> mm/vmstat.c:476:1: error: macro "raw_cpu_generic_xchg" requires 2 arguments, but only 1 given v = this_cpu_xchg(p->vm_stat_diff[i], 0); ^ ~~~~~~~~~~~~ In file included from arch/blackfin/include/generated/asm/percpu.h:1:0, from include/linux/percpu.h:12, from include/linux/percpu-rwsem.h:6, from include/linux/fs.h:30, from mm/vmstat.c:12: >> include/asm-generic/percpu.h:152:10: error: 'raw_cpu_generic_xchg' undeclared (first use in this function) __ret = raw_cpu_generic_xchg(pcp); \ ^ >> include/asm-generic/percpu.h:382:36: note: in expansion of macro 'this_cpu_generic_xchg' #define this_cpu_xchg_1(pcp, nval) this_cpu_generic_xchg(pcp, nval) ^~~~~~~~~~~~~~~~~~~~~ >> include/linux/percpu-defs.h:323:24: note: in expansion of macro 'this_cpu_xchg_1' case 1: pscr2_ret__ = stem##1(variable, __VA_ARGS__); break; \ ^~~~ >> include/linux/percpu-defs.h:500:34: note: in expansion of macro '__pcpu_size_call_return2' #define this_cpu_xchg(pcp, nval) __pcpu_size_call_return2(this_cpu_xchg_, pcp, nval) ^~~~~~~~~~~~~~~~~~~~~~~~ >> mm/vmstat.c:476:8: note: in expansion of macro 'this_cpu_xchg' v = this_cpu_xchg(p->vm_stat_diff[i], 0); ^~~~~~~~~~~~~ include/asm-generic/percpu.h:152:10: note: each undeclared identifier is reported only once for each function it appears in __ret = raw_cpu_generic_xchg(pcp); \ ^ >> include/asm-generic/percpu.h:382:36: note: in expansion of macro 'this_cpu_generic_xchg' #define this_cpu_xchg_1(pcp, nval) this_cpu_generic_xchg(pcp, nval) ^~~~~~~~~~~~~~~~~~~~~ >> include/linux/percpu-defs.h:323:24: note: in expansion of macro 'this_cpu_xchg_1' case 1: pscr2_ret__ = stem##1(variable, __VA_ARGS__); break; \ ^~~~ >> include/linux/percpu-defs.h:500:34: note: in expansion of macro '__pcpu_size_call_return2' #define this_cpu_xchg(pcp, nval) __pcpu_size_call_return2(this_cpu_xchg_, pcp, nval) ^~~~~~~~~~~~~~~~~~~~~~~~ >> mm/vmstat.c:476:8: note: in expansion of macro 'this_cpu_xchg' v = this_cpu_xchg(p->vm_stat_diff[i], 0); ^~~~~~~~~~~~~ >> mm/vmstat.c:476:1: error: macro "raw_cpu_generic_xchg" requires 2 arguments, but only 1 given v = this_cpu_xchg(p->vm_stat_diff[i], 0); ^ ~~~~~~~~~~~~ >> mm/vmstat.c:476:1: error: macro "raw_cpu_generic_xchg" requires 2 arguments, but only 1 given >> mm/vmstat.c:476:1: error: macro "raw_cpu_generic_xchg" requires 2 arguments, but only 1 given vim +/raw_cpu_generic_xchg +476 mm/vmstat.c ee99c71c KOSAKI Motohiro 2009-03-31 470 for_each_populated_zone(zone) { fbc2edb0 Christoph Lameter 2013-09-11 471 struct per_cpu_pageset __percpu *p = zone->pageset; 2244b95a Christoph Lameter 2006-06-30 472 fbc2edb0 Christoph Lameter 2013-09-11 473 for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) { a7f75e25 Christoph Lameter 2008-02-04 474 int v; a7f75e25 Christoph Lameter 2008-02-04 475 fbc2edb0 Christoph Lameter 2013-09-11 @476 v = this_cpu_xchg(p->vm_stat_diff[i], 0); fbc2edb0 Christoph Lameter 2013-09-11 477 if (v) { fbc2edb0 Christoph Lameter 2013-09-11 478 a7f75e25 Christoph Lameter 2008-02-04 479 atomic_long_add(v, &zone->vm_stat[i]); :::::: The code at line 476 was first introduced by commit :::::: fbc2edb05354480a88aa39db8a6acb5782fa1a1b vmstat: use this_cpu() to avoid irqon/off sequence in refresh_cpu_vm_stats :::::: TO: Christoph Lameter :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation