From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:52966 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573AbcIVHMO (ORCPT ); Thu, 22 Sep 2016 03:12:14 -0400 From: Jiri Slaby To: stable@vger.kernel.org Cc: James C Boyd , Jiri Kosina , Willy Tarreau , Jiri Slaby Subject: [patch added to 3.12-stable] HID: hid-input: Add parentheses to quell gcc warning Date: Thu, 22 Sep 2016 09:11:49 +0200 Message-Id: <20160922071154.1297-37-jslaby@suse.cz> In-Reply-To: <20160922071154.1297-1-jslaby@suse.cz> References: <20160922071154.1297-1-jslaby@suse.cz> Sender: stable-owner@vger.kernel.org List-ID: From: James C Boyd This patch has been added to the 3.12 stable tree. If you have any objections, please let us know. =============== commit 09a5c34e8d6b05663ec4c3d22b1fbd9fec89aaf9 upstream. GCC reports a -Wlogical-not-parentheses warning here; therefore add parentheses to shut it up and to express our intent more. Signed-off-by: James C Boyd Signed-off-by: Jiri Kosina Cc: Willy Tarreau Signed-off-by: Jiri Slaby --- drivers/hid/hid-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 8c58c820488c..5fbb46fe6ebf 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1109,7 +1109,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct return; /* report the usage code as scancode if the key status has changed */ - if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value) + if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value) input_event(input, EV_MSC, MSC_SCAN, usage->hid); input_event(input, usage->type, usage->code, value); -- 2.10.0