All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()
@ 2016-09-17 16:01 Wei Yongjun
  2016-09-19 15:09 ` Gary R Hook
  2016-09-22 10:45 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-09-17 16:01 UTC (permalink / raw)
  To: Tom Lendacky, Gary Hook, Herbert Xu; +Cc: Wei Yongjun, linux-crypto

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the retrn value check which testing the wrong variable
in ccp_dmaengine_register().

Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
index 94f77b0..32f645e 100644
--- a/drivers/crypto/ccp/ccp-dmaengine.c
+++ b/drivers/crypto/ccp/ccp-dmaengine.c
@@ -650,7 +650,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
 	dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
 					     "%s-dmaengine-desc-cache",
 					     ccp->name);
-	if (!dma_cmd_cache_name)
+	if (!dma_desc_cache_name)
 		return -ENOMEM;
 	ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
 						sizeof(struct ccp_dma_desc),

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()
  2016-09-17 16:01 [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register() Wei Yongjun
@ 2016-09-19 15:09 ` Gary R Hook
  2016-09-22 10:45 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Gary R Hook @ 2016-09-19 15:09 UTC (permalink / raw)
  To: Wei Yongjun, Tom Lendacky, Gary Hook, Herbert Xu
  Cc: Wei Yongjun, linux-crypto

On 09/17/2016 11:01 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the retrn value check which testing the wrong variable
> in ccp_dmaengine_register().
>
> Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/crypto/ccp/ccp-dmaengine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index 94f77b0..32f645e 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -650,7 +650,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
>  	dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
>  					     "%s-dmaengine-desc-cache",
>  					     ccp->name);
> -	if (!dma_cmd_cache_name)
> +	if (!dma_desc_cache_name)
>  		return -ENOMEM;
>  	ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
>  						sizeof(struct ccp_dma_desc),
>

Acked-by: Gary R Hook <gary.hook@amd.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register()
  2016-09-17 16:01 [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register() Wei Yongjun
  2016-09-19 15:09 ` Gary R Hook
@ 2016-09-22 10:45 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2016-09-22 10:45 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: Tom Lendacky, Gary Hook, Wei Yongjun, linux-crypto

On Sat, Sep 17, 2016 at 04:01:22PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the retrn value check which testing the wrong variable
> in ccp_dmaengine_register().
> 
> Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA resource")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-22 10:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-17 16:01 [PATCH] crypto: ccp - Fix return value check in ccp_dmaengine_register() Wei Yongjun
2016-09-19 15:09 ` Gary R Hook
2016-09-22 10:45 ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.