All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v3] docs/manual: update the linux tools section
Date: Thu, 22 Sep 2016 12:56:55 +0200	[thread overview]
Message-ID: <20160922125655.69a5b900@free-electrons.com> (raw)
In-Reply-To: <bdadcf3de3e5617f0492d88329476963a06fad44.1473171931.git.yann.morin.1998@free.fr>

Hello,

On Tue,  6 Sep 2016 16:29:15 +0200, Yann E. MORIN wrote:

>  ------------------------------
> -01: config BR2_LINUX_KERNEL_TOOL_FOO
> +01: config BR2_PACKAGE_LINUX_TOOLS_FOO
>  02: 	bool "foo"

This example lacks the "select BR2_PACKAGE_LINUX_TOOLS" which I believe
is now very important to mention.


> +16: 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/linux/tools \

Why $(@D)/linux/tools ? This doesn't seem right. I've changed it to
$(LINUX_DIR)/tools, which is what packages really use.

Committed with those issues fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2016-09-22 10:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 14:29 [Buildroot] [PATCH 0/2 v3] linux/tools: move to their own package (branch yem/linux-tools) Yann E. MORIN
2016-09-06 14:29 ` [Buildroot] [PATCH 1/2 v3] linux/tools: make it a real, separate package Yann E. MORIN
2016-09-22 10:51   ` Thomas Petazzoni
2016-09-22 16:33     ` Yann E. MORIN
2016-09-22 14:58   ` Peter Korsgaard
2016-09-22 17:49     ` Thomas Petazzoni
2016-09-22 18:01       ` Peter Korsgaard
2016-09-22 18:14         ` Thomas Petazzoni
2016-09-22 18:17           ` Peter Korsgaard
2016-09-06 14:29 ` [Buildroot] [PATCH 2/2 v3] docs/manual: update the linux tools section Yann E. MORIN
2016-09-22 10:56   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922125655.69a5b900@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.