From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757466AbcIVQYm (ORCPT ); Thu, 22 Sep 2016 12:24:42 -0400 Received: from mail-by2nam01on0054.outbound.protection.outlook.com ([104.47.34.54]:15474 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755949AbcIVQYk (ORCPT ); Thu, 22 Sep 2016 12:24:40 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Thu, 22 Sep 2016 18:08:32 +0200 From: Jan Glauber To: Wolfram Sang CC: , , "Bazhenov, Dmitry" Subject: Re: [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction Message-ID: <20160922160832.GA2734@hardcore> References: <21b1db0af4c62a53dc2fcec1e0b1f7b412e6f1be.1474439371.git.jglauber@cavium.com> <20160921205540.GC1513@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160921205540.GC1513@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.223.65.126] X-ClientProxiedBy: DB5PR02CA0020.eurprd02.prod.outlook.com (10.161.237.30) To CO2PR07MB2581.namprd07.prod.outlook.com (10.166.201.20) X-MS-Office365-Filtering-Correlation-Id: 12fb0665-9761-4620-06c7-08d3e302ba03 X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2581;2:r//rZWyOnwM9mKNqAgxO+ReryFpYvXW18H8t+fXtWgxwINR7qiciCMmUHqiowZQOM9QbSQMyrD1FubSMCvFHOV0baH2e3uo5YYLAVw8d3sXcP4BGKRBsQrDMdpCPmG7KCPL1j4WxCVHhvOmaMalrCBBN4FoZX/gso2gCJzWbXem/3Nc+kkgHldEW8DNbSJqA;3:3c7AZS38czAMwY5GSKG7+/5ju1HexIyAUihClAwvV70vk/ghLHwX4LvTwAQSNSE3f55nX+GLMQdcOdbJp0jNq/THQIBvZj7eDOlgrMe8D73iQ5ENayVRentCLqgJTJlZ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2581; X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2581;25:fCvnhfCIge/Rtl2zm4VcQUBK53r+GzH1mUnqpdRTSfCPIzRZVS8u8/KFQ93ocEg+eq8/2PT/s+378svPQ9pPJHCmqjDNshJ63F6onoMopL7/ZUj3ykxjFBCd0zgoEg3RmLiQJ9t+BsM+TARu699zCiq7Zdm+bYNGHdtUtHdAgJs+zFND9PRg7e5BPy6sH2wcxLr45eRjxY7WhWqEGT7kSXtXC1zHqwuQ328FF7XRRZBba+ut2mKWwjukbe05/tIBfb7Xbzi1qKpQlb+oYEFTilBMxfv73qL5OQLn7Qqft9Q7oofbaVD+okFoB9Py3HHVo5bdS1Us7HQAONYVhuSb0ADUeegrJlvsKCD+jTHSxWWLeghnGmp4WtIk3mKHk7QWZpr67ooFmScMoPB4BS/F/gitJjElp5SxDhfysroENy2vZ41ypCvpmEkLaf3lZ12oI7d/jm2VkFV9RC9LqdMnxwYQfHiqzyw2oFxX+jl4z9vwZG+zIYFFmm4x8R2/CCAcUerHxqrPUBTp5pdvp2vvO66R2wCk60kj2TnTr14ZUBuW5BgTtwVHBNLw9j7thdXEraHLdh5jSU3D2C9T80Gzj2QIxLWVJAnl6YLEtDZJ+rYkRNTW2Z9TCb3Pr/Bl8s+7hD90EKCvtn6/ycLhiMJbdjLRHDthNdzyyq0dwFibdI90m0GZb4CIAdm5bOV6WzLxOgxfbsOPa/DF80ORg3Ph2fzGAG8wmnsBcwMvWyJdZaY= X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2581;31:yQMRSgoOwlNpTjKhVDvmKLxWwQa0PjH1blETyweRdyU8KuliGyEwL7DSDOgqLx5n+UVIof89W6PLAM1+JEHGh77UwmqOD1eYjgLRw5ggBlzqVuwfLVTXIP07tiw9y2rFQlvip+MnFEFr6KAKVEIsrtvJRWIGfgQieBsN/eq9gF0u3Y475ehv3mogLfPVvs8XiicNuLqpPtYdAfOW744agXeZKfttLlYxY4nH33CJRuI=;20:UZ+xTdkuO7mxgsni6iBDbTN2SVxYUAl63xwV1jhVL5mdB86kC9lGQVUCti31cLQPU+GjNr+dHVDRZyt7r1eLzkHwK9ZkEdv7yCMx2biDrWB/mqTnk24v/CTLyEkDGieP1jOS/1jZUwmS8yBstygCWYFww3fC6A5IdZ0bVDBtTL6NNafj+lDwoRV/1FTclJ8ohuWvgEFUAsrFkVVj2lwfmAVEEIHVPrwn7F+P/AGYEaihkxzufuVs18PLg2SPubYH6OYOk5i1LVpetwKFrg7le49o/FWqh/PERoxgq0F/51hV1YoxQlJ1ZwyPbHqrOH2C0C7001wJkwCiS0eJMfJh03oM+nQoZzN3+Xf6naErBem37M5LDLn5uqQFzvTkLByRGZCgG9neyWdt6wWhnCHmbKHIN/7gBJ0AMyjnPhQMDh/lVv1GdlOsmH3chZrarFhAWhLrCyVy9dsY1Ek2hxHewHYKmjJDtHonnCEF4nKlPAk6Ds0zGRWFKHRXD9mF0v6dl9O3wSBuJmOTfvdnH87NAkyvlfOdXi4NJpEmZ08vYMc4wO09GahDzVOcVCNXJvui2p0YkHoJJ2zax01SmUDMhXgafZPmtumYTJqIZdxFOTQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CO2PR07MB2581;BCL:0;PCL:0;RULEID:;SRVR:CO2PR07MB2581; X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2581;4:wut53TaBQlIkF9bkIIs5cc2ZfHDqHva8tRVfH/1a/hT1qPn2GQGUHk8/dSrpoLadnHBpHQjpIbSERFB32UWNJ+uTBJLs+k5dQveiVERxdEHZKv8OM4x6rAPqk7zUOmPWpafor8+aCJtfRWeAH3Aea5MSAMLTj7zGQ0PldXaPTyYc9OzMYijtRnlfvmRiU0Q+hG1tGNKvg5ABry2k9CL7FR/1hzehZxBdLca5vcRhmiFzB2JZInfMiZAx88q7OrBQlC1NI4Av4YL93rbZbC86zvnroI1BmYrU/0osXyU28LOfuWFEkIIyYkfZ6y+HbREImD53YlTt7fWrM/9bkKKGBP/g+MkLYBWjC+6Iget3vblOb+LnOsgACUWSIY+UfO3fZUNehY/wOL3ALKMkRBTABA== X-Forefront-PRVS: 0073BFEF03 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(33656002)(101416001)(189998001)(9686002)(19580405001)(50466002)(1076002)(586003)(4001350100001)(97736004)(6116002)(23726003)(3846002)(305945005)(5660300001)(83506001)(47776003)(92566002)(46406003)(7736002)(7846002)(110136003)(97756001)(106356001)(76176999)(81156014)(54356999)(19580395003)(50986999)(2950100001)(68736007)(42186005)(8676002)(2906002)(81166006)(77096005)(105586002)(33716001)(4326007)(66066001)(551934003)(18370500001)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR07MB2581;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO2PR07MB2581;23:1WL8k9FmIEsCNVYdL6q6IAiiErHkVe+H9nAuDJZT4?= =?us-ascii?Q?d4x46XuoUKj9w/7X+Q/80O670/8mPNjqVpfnABYz7C2H3L7urk5y5xWkqdo1?= =?us-ascii?Q?qQMv6JGXMlVjszfJis3kzT6OMiOuXGTF2SPEnjbR5q3Xn+ipa/hczTR3rgbp?= =?us-ascii?Q?rCEAJpqGJZd2qLqpD88ZGsNIfgsyrxkNvAThuS5sy5sr4DfCslL8koqq4Fci?= =?us-ascii?Q?lZE161Kj/IK9s3cfCbqauA+LZASRZrSg1weN4ruKN5BEGRNbMcxGdNfg1Cwv?= =?us-ascii?Q?+3/Sy0ZsKIwzprrji1fy6OzxqG7Mb4HqzQm8wPNI8HDMghyHj1HgU6ewQsRW?= =?us-ascii?Q?NQ9ZHoDeNFokcEmWqFnSsNtByH3vMs3ReWttAL8n4Ityh6HM1Nz2ztY5hWp6?= =?us-ascii?Q?QQyX1NIoTcyDhzQsUytmlQJfGCwItW3FaA1sfqc/SpziASZoAMh8QM+XUA1B?= =?us-ascii?Q?4QGEWEsZQVT/qLJ3KOlp/Ufyh/uT4xg6oyhhi7adNFDYsUMSOXfGHcgkfma8?= =?us-ascii?Q?vv7IY5GrfLucXLVPWa0aDLrKkGfkT36KScN12M7JSxoyk4akC5KlZNQDy7Wr?= =?us-ascii?Q?q3dcaT2xzNZ5J5l5sJOyyQRwg2H2IXkpGtpk1HOkYiB9ezHCuJRKblH2AnbT?= =?us-ascii?Q?oXfbxd7H35TGcMggjQk/Qn9LFLUgEi+svjvfBMpsnkR3pw2QnV4wL1SliGkm?= =?us-ascii?Q?BuDc/NetAztcm89nUHjaRRcSYKIue9dJRrHU2JjWpv51I9HmxkSYgMZOG+62?= =?us-ascii?Q?yAAxfwQ03M+bYypuKhwFPwqY+bCyxkoQJ5oUVxMyJnG1u5NTafqqU9REpdpz?= =?us-ascii?Q?zDGtiHKJLro6QrPF5fyDjxPvLYPVx6GyE3KwJsiUAMVx0u25xulFGYEbvsMz?= =?us-ascii?Q?pZkLlWnFnkkT01gKLR/SaWT/QWb39B8uM+pPECyJh2VLh+BqczFu0QJko2bS?= =?us-ascii?Q?qB1HkaZ0//MhhJd1YvAfqVNXdLNpeUbkdq7F3QWQf1wS/vqGHbR3MLFn1CSz?= =?us-ascii?Q?QXUjkyuxmCsgYVRngc11v5GuoiyETbt/MEmeWM66owWCNK0c9uMCaihZ3oGT?= =?us-ascii?Q?aqw0/ha+0ZgW07Y+9sxSSCZfwb9fCAhyHXR4zr3LSBt6fNrVqP1anMRsQfC7?= =?us-ascii?Q?UuGX6aN+NbOuKj6xkgVg2L53Y6nq4HZ6mpjTfFIEZtOR1+a5D6F1uys4rzCS?= =?us-ascii?Q?SpFZUbzzUUZEyaMg3wMIfrJ+2Tq6vlinEUPDCo2EMu3+Oz6gXrrABueag=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR07MB2581;6:iibV99IU1bQ4YVoGz7Ek056+Trw4WMug2lZl1KtYoSPfDZrIMSi4KE7seTAk/NHR2uWi75EB9WObrHltMLxy6rNXC1vkfWxFWefZEe82DvQn/STFbPeD61h50JeLAsP0hjWXocMIrTmcTXexnmKo81HkA4bTxNIDpJQfEb97M6WBLUzYip9Wu86x5eL/GtvnwfNcxknUvYdV27DjhjeOBSaBK/2/zV3I8jZxRcvfZ57fJAkqntw9Ikq8AQDc17evWAGKufxYhR2K3ARLConJp5+jlCrqvvK4z7U31JEYHEE=;5:UdIRWaj30lV46RRhw5u3xwC+TIO9Xx2PYY4a92ZlqWmxAQtcrGQ14Nr2cuB13eXzP1uzrx4+TI4TCqMR4X3MODZm/JtBEHiuNQ9OQzXVIdfpCDvd1dAjuOhf6fT1PKhtRk74uXB/haQjOOiPg+GVig==;24:ZMYAgyULRpQKhC17ewJOURVUVrD2VuKDPJu3RmS1idDXKn7rC45r42agDghzh5XetAf7L6lHfQ42zi5hpQPEdlqknHb6Ce+aFppmvWPbPOg=;7:s8fLSBE/PB1S7Yr/BndbIg0HnP0pyjl0EcGEJi3Cl4+TwI00LwgMOZP2jQkV+Y7Sd2jvMiod+Rj5KFCX8Bm0K1eipAQAnBcW/7fNGKshDekmTt2mBPCiKOjXoYQUJbYdQ0aZe8TxCuTr4p9QxF+vLAhAI15QS6rSLpf7+DshhynukOay+Hb42u86Dpv+zlLmQkWRC+xqMLocq5giBwGEpvc2YO/XS6uRbgsbOO9EdGKHfl0vC3vWAsZfJiRQxvj4sJytm3PFLU6GC9KXp4iWsqbh1oJCOCiDSK0OF/wDyOQjLT7Al6ozmT6SjSWq4jwy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2016 16:08:42.6251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2581 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 10:55:41PM +0200, Wolfram Sang wrote: > On Wed, Sep 21, 2016 at 08:51:05AM +0200, Jan Glauber wrote: > > Add an additional status check before starting a transaction and, > > if required, trigger the recovery if the check fails. > > > > Signed-off-by: Jan Glauber > > Won't this break multi-master setups? > I'm afraid yes. I don't have a multi-master setup, but agree that we should not break it. How about re-checking if the bus is idle until a timeout (i2c->adap.timeout ?) happens and only then recover? Additionaly we can check for arbitration loss as Dmitry did in his original patch. --Jan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Glauber Subject: Re: [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction Date: Thu, 22 Sep 2016 18:08:32 +0200 Message-ID: <20160922160832.GA2734@hardcore> References: <21b1db0af4c62a53dc2fcec1e0b1f7b412e6f1be.1474439371.git.jglauber@cavium.com> <20160921205540.GC1513@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail-sn1nam01on0076.outbound.protection.outlook.com ([104.47.32.76]:50614 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754510AbcIVQIq (ORCPT ); Thu, 22 Sep 2016 12:08:46 -0400 Content-Disposition: inline In-Reply-To: <20160921205540.GC1513@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, "Bazhenov, Dmitry" On Wed, Sep 21, 2016 at 10:55:41PM +0200, Wolfram Sang wrote: > On Wed, Sep 21, 2016 at 08:51:05AM +0200, Jan Glauber wrote: > > Add an additional status check before starting a transaction and, > > if required, trigger the recovery if the check fails. > > > > Signed-off-by: Jan Glauber > > Won't this break multi-master setups? > I'm afraid yes. I don't have a multi-master setup, but agree that we should not break it. How about re-checking if the bus is idle until a timeout (i2c->adap.timeout ?) happens and only then recover? Additionaly we can check for arbitration loss as Dmitry did in his original patch. --Jan