All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com,
	kevin@koconnor.net, lersek@redhat.com, chao.gao@intel.com,
	peterx@redhat.com, liuxiaojian6@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2 10/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode
Date: Thu, 22 Sep 2016 21:57:39 +0200	[thread overview]
Message-ID: <20160922195739.GA25077@potion> (raw)
In-Reply-To: <c2894c4b-df60-fa0b-6ed9-36a67fa1da9d@redhat.com>

2016-09-22 16:36+0200, Paolo Bonzini:
> On 22/09/2016 14:50, Igor Mammedov wrote:
>> +#ifdef KVM_CAP_X2APIC_API
>> +    if (kvm_check_extension(s, KVM_CAP_X2APIC_API)) {
>> +        has_x2apic_ids = !kvm_vm_enable_cap(s, KVM_CAP_X2APIC_API, 0,
>> +                                            KVM_X2APIC_API_USE_32BIT_IDS);
>> +    }
>> +#endif
>> +
> 
> Radim, whose patches are going to set
> KVM_X2APIC_API_DISABLE_BROADCAST_QUIRK?

I added kvm_enable_x2apic() helper for intel_iommu that enables both,
because we really want to make sure that both are enabled before
allowing EIM.  (And then I didn't post those patches ... ameding that
after a rebase and a quick retest.)

We'd better forbid APIC IDs above 255 without "intel_iommu,eim=on", so
reusing kvm_enable_x2apic() and enabling both in Igor's patches would be
just a bit nicer.

Having separate KVM_X2APIC_API_USE_32BIT_IDS and
KVM_X2APIC_API_DISABLE_BROADCAST_QUIRK isn't as useful as I thought it
would be ...

  reply	other threads:[~2016-09-22 19:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 12:50 [Qemu-devel] [PATCH v2 00/14] pc: q35: x2APIC support in kvm_apic mode Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 01/14] numa: reduce code duplication by adding helper numa_get_node_for_cpu() Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 02/14] pc: acpi: x2APIC support for MADT table Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 03/14] pc: acpi: x2APIC support for SRAT table Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 04/14] acpi: cphp: support x2APIC entry in cpu._MAT Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 05/14] acpi: cphp: force switch to modern cpu hotplug if APIC ID > 254 Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 06/14] pc: leave max apic_id_limit only in legacy cpu hotplug code Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit Igor Mammedov
2016-09-22 14:37   ` Paolo Bonzini
2016-09-22 16:00     ` Igor Mammedov
2016-09-22 16:16       ` Paolo Bonzini
2016-09-26 11:10         ` Igor Mammedov
2016-09-26 11:22           ` Paolo Bonzini
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 08/14] pc: apic_common: restore APIC ID to initial ID on reset Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 09/14] pc: apic_common: reset APIC ID to initial ID when switching into x2APIC mode Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 10/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode Igor Mammedov
2016-09-22 14:36   ` Paolo Bonzini
2016-09-22 19:57     ` Radim Krčmář [this message]
2016-09-26  9:47       ` Igor Mammedov
2016-09-27 14:13         ` Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 11/14] pc: clarify FW_CFG_MAX_CPUS usage comment Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 12/14] increase MAX_CPUMASK_BITS from 255 to 288 Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 13/14] pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 14/14] pc: q35: bump max_cpus to 288 Igor Mammedov
2016-09-22 14:46 ` [Qemu-devel] [PATCH v2 00/14] pc: q35: x2APIC support in kvm_apic mode no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922195739.GA25077@potion \
    --to=rkrcmar@redhat.com \
    --cc=chao.gao@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=lersek@redhat.com \
    --cc=liuxiaojian6@huawei.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.