All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org,
	tipbuild@zytor.com
Subject: [PATCH] objtool: add do_task_dead() to global noreturn list
Date: Thu, 22 Sep 2016 16:21:25 -0500	[thread overview]
Message-ID: <20160922212125.zbuewckqll4yur25@treble> (raw)
In-Reply-To: <201609230208.d3pdLI2R%fengguang.wu@intel.com>

objtool reports the following warning:

  kernel/exit.o: warning: objtool: do_exit() falls through to next function complete_and_exit()

The warning is caused by do_exit()'s new call to do_task_dead(), which
is a new "noreturn" function which objtool doesn't know about yet.

(objtool has to know all the global noreturn functions so it can follow
the control flow of any functions which call them.  Unfortunately they
need to be hard-coded becuase there's not an automated way to detect
them.)

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 tools/objtool/builtin-check.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
index bd09d0e..143b6cd 100644
--- a/tools/objtool/builtin-check.c
+++ b/tools/objtool/builtin-check.c
@@ -175,6 +175,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
 		"__stack_chk_fail",
 		"panic",
 		"do_exit",
+		"do_task_dead",
 		"__module_put_and_exit",
 		"complete_and_exit",
 		"kvm_spurious_fault",
-- 
2.7.4

  reply	other threads:[~2016-09-22 21:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 18:37 [tip:sched/core 44/47] kernel/exit.o: warning: objtool: do_exit() falls through to next function complete_and_exit() kbuild test robot
2016-09-22 21:21 ` Josh Poimboeuf [this message]
2016-09-23  5:33   ` [tip:sched/core] objtool: Add do_task_dead() to global noreturn list tip-bot for Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922212125.zbuewckqll4yur25@treble \
    --to=jpoimboe@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tipbuild@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.