All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] imx: mx6ullevk: support plugin
Date: Fri, 23 Sep 2016 15:28:50 +0800	[thread overview]
Message-ID: <20160923072848.GA1515@linux-u7w5.ap.freescale.net> (raw)
In-Reply-To: <20160922154816.GU4814@bill-the-cat>

On Thu, Sep 22, 2016 at 11:48:16AM -0400, Tom Rini wrote:
>On Mon, Sep 19, 2016 at 11:55:43AM +0800, van.freenix at gmail.com wrote:
>
>> From: Peng Fan <peng.fan@nxp.com>
>> 
>> Add plugin code for mx6ullevk.
>> Define CONFIG_USE_PLUGIN in include/configs/mx6ullevk.h to use plugin code.
>> 
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>
>So we need an option in arch/arm/cpu/armv7/mx6/Kconfig to offer plugin
>support, and 'USE_PLUGIN' is too generic of a name.  Perhaps
>USE_IMXIMG_PLUGIN ?

Yeah. Will include this only for plugin board code. About host tools,
I'll try to make PLUGIN always be there.

>
>> ---
>>  board/freescale/mx6ullevk/Makefile |   4 ++
>>  board/freescale/mx6ullevk/plugin.S | 139 +++++++++++++++++++++++++++++++++++++
>>  2 files changed, 143 insertions(+)
>>  create mode 100644 board/freescale/mx6ullevk/plugin.S
>> 
>> diff --git a/board/freescale/mx6ullevk/Makefile b/board/freescale/mx6ullevk/Makefile
>> index c64fba4..0ee905b 100644
>> --- a/board/freescale/mx6ullevk/Makefile
>> +++ b/board/freescale/mx6ullevk/Makefile
>> @@ -4,3 +4,7 @@
>>  #
>>  
>>  obj-y  := mx6ullevk.o
>> +
>> +extra-$(CONFIG_USE_PLUGIN) :=  plugin.bin
>> +$(obj)/plugin.bin: $(obj)/plugin.o
>> +	$(OBJCOPY) -O binary --gap-fill 0xff $< $@
>
>And then we can move this logic up a bit higher and say that
>$(BOARDDIR)/plugin.S will make $(BOARDDIR)/plugin.bin or so

Will add this to arch/arm/imx-common/Makefile.

Thanks,
Peng.

>
>Thanks!
>
>-- 
>Tom



-- 

  reply	other threads:[~2016-09-23  7:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19  3:55 [U-Boot] [PATCH 1/5] tools: imximage: add plugin support van.freenix at gmail.com
2016-09-19  3:55 ` [U-Boot] [PATCH 2/5] imx: mx6: Add " van.freenix at gmail.com
2016-09-19  3:55 ` [U-Boot] [PATCH 3/5] imx: mx7: " van.freenix at gmail.com
2016-09-19  3:55 ` [U-Boot] [PATCH 4/5] imx: mx6ullevk: support plugin van.freenix at gmail.com
2016-09-22 15:48   ` Tom Rini
2016-09-23  7:28     ` Peng Fan [this message]
2016-09-23  8:35     ` Peng Fan
2016-09-23 18:43       ` Tom Rini
2016-09-19  3:55 ` [U-Boot] [PATCH 5/5] imx: mx6ullevk: correct boot device macro van.freenix at gmail.com
2016-09-22 15:48 ` [U-Boot] [PATCH 1/5] tools: imximage: add plugin support Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160923072848.GA1515@linux-u7w5.ap.freescale.net \
    --to=van.freenix@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.