From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Fri, 23 Sep 2016 16:35:59 +0800 Subject: [U-Boot] [PATCH 4/5] imx: mx6ullevk: support plugin In-Reply-To: <20160922154816.GU4814@bill-the-cat> References: <1474257344-12962-1-git-send-email-peng.fan@nxp.com> <1474257344-12962-4-git-send-email-peng.fan@nxp.com> <20160922154816.GU4814@bill-the-cat> Message-ID: <20160923080521.GA5828@linux-u7w5.ap.freescale.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Sep 22, 2016 at 11:48:16AM -0400, Tom Rini wrote: >On Mon, Sep 19, 2016 at 11:55:43AM +0800, van.freenix at gmail.com wrote: > >> From: Peng Fan >> >> Add plugin code for mx6ullevk. >> Define CONFIG_USE_PLUGIN in include/configs/mx6ullevk.h to use plugin code. >> >> Signed-off-by: Peng Fan >> Cc: Stefano Babic > >So we need an option in arch/arm/cpu/armv7/mx6/Kconfig to offer plugin >support, and 'USE_PLUGIN' is too generic of a name. Perhaps >USE_IMXIMG_PLUGIN ? > >> --- >> board/freescale/mx6ullevk/Makefile | 4 ++ >> board/freescale/mx6ullevk/plugin.S | 139 +++++++++++++++++++++++++++++++++++++ >> 2 files changed, 143 insertions(+) >> create mode 100644 board/freescale/mx6ullevk/plugin.S >> >> diff --git a/board/freescale/mx6ullevk/Makefile b/board/freescale/mx6ullevk/Makefile >> index c64fba4..0ee905b 100644 >> --- a/board/freescale/mx6ullevk/Makefile >> +++ b/board/freescale/mx6ullevk/Makefile >> @@ -4,3 +4,7 @@ >> # >> >> obj-y := mx6ullevk.o >> + >> +extra-$(CONFIG_USE_PLUGIN) := plugin.bin >> +$(obj)/plugin.bin: $(obj)/plugin.o >> + $(OBJCOPY) -O binary --gap-fill 0xff $< $@ > >And then we can move this logic up a bit higher and say that >$(BOARDDIR)/plugin.S will make $(BOARDDIR)/plugin.bin or so Seems put the code in arch/arm/imx-common/Makefile does not work. Add this into root dir Makefile? I tend to keep in board file now, since this is for board usage. Thanks, Peng. > >Thanks! > >-- >Tom --