From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:34140 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbcIWIZq (ORCPT ); Fri, 23 Sep 2016 04:25:46 -0400 Received: by mail-pf0-f169.google.com with SMTP id p64so39921619pfb.1 for ; Fri, 23 Sep 2016 01:25:46 -0700 (PDT) Date: Fri, 23 Sep 2016 17:32:58 +0900 From: AKASHI Takahiro To: Greg KH Cc: catalin.marinas@arm.com, will.deacon@arm.com, jason.wessel@windriver.com, linux-arm-kernel@lists.infradead.org, kgdb-bugreport@lists.sourceforge.net, stable@vger.kernel.org Subject: Re: [PATCH v2 0/3] arm64: kgdb: fix single stepping Message-ID: <20160923083257.GL30248@linaro.org> References: <20160923073327.9657-1-takahiro.akashi@linaro.org> <20160923081618.GH18056@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <20160923081618.GH18056@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Sep 23, 2016 at 10:16:18AM +0200, Greg KH wrote: > On Fri, Sep 23, 2016 at 04:33:24PM +0900, AKASHI Takahiro wrote: > > Kgdb support on arm64 was merged in v3.15, but from its first appearance, > > "signle step" has never worked well. > > > > This patch fixes all the error cases I found so far. > > The original patch[1] was splitted into three pieces, ones for each case. > > patch#1, #2 should be applied to all the version, v3.15 and later. > > pathc#3 only for v3.16 and later. > > As this is not a regression (i.e. it has never worked), why is this > something for stable releases? Because, I think, that is a bug. The author seems to have believed that it worked. Please see: commit 44679a4f Author: Vijaya Kumar K Date: Tue Jan 28 11:20:19 2014 +0000 arm64: KGDB: Add step debugging support Thanks, -Takahiro AKASHI > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: takahiro.akashi@linaro.org (AKASHI Takahiro) Date: Fri, 23 Sep 2016 17:32:58 +0900 Subject: [PATCH v2 0/3] arm64: kgdb: fix single stepping In-Reply-To: <20160923081618.GH18056@kroah.com> References: <20160923073327.9657-1-takahiro.akashi@linaro.org> <20160923081618.GH18056@kroah.com> Message-ID: <20160923083257.GL30248@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 23, 2016 at 10:16:18AM +0200, Greg KH wrote: > On Fri, Sep 23, 2016 at 04:33:24PM +0900, AKASHI Takahiro wrote: > > Kgdb support on arm64 was merged in v3.15, but from its first appearance, > > "signle step" has never worked well. > > > > This patch fixes all the error cases I found so far. > > The original patch[1] was splitted into three pieces, ones for each case. > > patch#1, #2 should be applied to all the version, v3.15 and later. > > pathc#3 only for v3.16 and later. > > As this is not a regression (i.e. it has never worked), why is this > something for stable releases? Because, I think, that is a bug. The author seems to have believed that it worked. Please see: commit 44679a4f Author: Vijaya Kumar K Date: Tue Jan 28 11:20:19 2014 +0000 arm64: KGDB: Add step debugging support Thanks, -Takahiro AKASHI > thanks, > > greg k-h