From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:56454 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033909AbcIWKXp (ORCPT ); Fri, 23 Sep 2016 06:23:45 -0400 Date: Fri, 23 Sep 2016 11:23:40 +0100 From: Catalin Marinas To: AKASHI Takahiro Cc: mark.rutland@arm.com, kgdb-bugreport@lists.sourceforge.net, will.deacon@arm.com, stable@vger.kernel.org, jason.wessel@windriver.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2.1] arm64: kgdb: handle read-only text / modules Message-ID: <20160923102340.GA2161@e104818-lin.cambridge.arm.com> References: <20160923074208.9899-1-takahiro.akashi@linaro.org> <20160923094953.GC27704@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923094953.GC27704@e104818-lin.cambridge.arm.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Sep 23, 2016 at 10:49:53AM +0100, Catalin Marinas wrote: > On Fri, Sep 23, 2016 at 04:42:08PM +0900, AKASHI Takahiro wrote: > > Handle read-only cases (CONFIG_DEBUG_RODATA/CONFIG_DEBUG_SET_MODULE_RONX) > > by using aarch64_insn_write() instead of probe_kernel_write(). > > See how this works: > > commit 2f896d586610 ("arm64: use fixmap for text patching") > > > > Signed-off-by: AKASHI Takahiro > > Reviewed-by: Mark Rutland > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Jason Wessel > > Cc: # 3.18-3.19: 2f896d5: arm64: use fixmap > > Cc: # 3.18-3.19: f6242ca: arm64: Fix text > > Cc: # 4.0- > > Queued for 4.8 with a slight change in the last Cc: tag above: > > Cc: # 3.18.x- I tried to apply this patch to 3.18, 4.1, 4.4, 4.7. It fails on all of them with smaller or slightly larger conflicts. So, I'll merge it in 4.8 without any "Cc: stable" tags, just a "Fixes:" one for the commit introducing CONFIG_DEBUG_SET_MODULE_RONX (3.18). Once the patch reaches mainline, could you please back-port and test it on the stable kernel versions and send separate patches to stable@vger.kernel.org? Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Fri, 23 Sep 2016 11:23:40 +0100 Subject: [PATCH v2.1] arm64: kgdb: handle read-only text / modules In-Reply-To: <20160923094953.GC27704@e104818-lin.cambridge.arm.com> References: <20160923074208.9899-1-takahiro.akashi@linaro.org> <20160923094953.GC27704@e104818-lin.cambridge.arm.com> Message-ID: <20160923102340.GA2161@e104818-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 23, 2016 at 10:49:53AM +0100, Catalin Marinas wrote: > On Fri, Sep 23, 2016 at 04:42:08PM +0900, AKASHI Takahiro wrote: > > Handle read-only cases (CONFIG_DEBUG_RODATA/CONFIG_DEBUG_SET_MODULE_RONX) > > by using aarch64_insn_write() instead of probe_kernel_write(). > > See how this works: > > commit 2f896d586610 ("arm64: use fixmap for text patching") > > > > Signed-off-by: AKASHI Takahiro > > Reviewed-by: Mark Rutland > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Jason Wessel > > Cc: # 3.18-3.19: 2f896d5: arm64: use fixmap > > Cc: # 3.18-3.19: f6242ca: arm64: Fix text > > Cc: # 4.0- > > Queued for 4.8 with a slight change in the last Cc: tag above: > > Cc: # 3.18.x- I tried to apply this patch to 3.18, 4.1, 4.4, 4.7. It fails on all of them with smaller or slightly larger conflicts. So, I'll merge it in 4.8 without any "Cc: stable" tags, just a "Fixes:" one for the commit introducing CONFIG_DEBUG_SET_MODULE_RONX (3.18). Once the patch reaches mainline, could you please back-port and test it on the stable kernel versions and send separate patches to stable at vger.kernel.org? Thanks. -- Catalin