From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965976AbcIWMRR (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 08:17:17 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:52808 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965493AbcIWMRN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 08:17:13 -0400
Date: Fri, 23 Sep 2016 14:17:18 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: giannis.damigos@gmail.com
Cc: markus.boehme@mailbox.org, arve@android.com, riandrews@android.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues
Message-ID: <20160923121718.GB21575@kroah.com>
References: <e8f40d73-9d0e-3c18-fcc3-be2bcdf0eaf3@mailbox.org>
 <20160923080517.421-1-giannis.damigos@gmail.com>
 <20160923080517.421-2-giannis.damigos@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160923080517.421-2-giannis.damigos@gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 23, 2016 at 11:05:14AM +0300, giannis.damigos@gmail.com wrote:
> From: Yannis Damigos <giannis.damigos@gmail.com>
> 
> This patch fixes the following whitespace issues:
> 
> CHECK: Alignment should match open parenthesis
> +int ion_parse_dt_heap_common(struct device_node *heap_node,
> +			struct ion_platform_heap *heap,
> 
> CHECK: Alignment should match open parenthesis
> +	pr_info("%s: id %d type %d name %s align %lx\n", __func__,
> +			heap->id, heap->type, heap->name, heap->align);
> 
> CHECK: Alignment should match open parenthesis
> +int ion_setup_heap_common(struct platform_device *parent,
> +			struct device_node *heap_node,
> 
> CHECK: Alignment should match open parenthesis
> +struct ion_platform_data *ion_parse_dt(struct platform_device *pdev,
> +					struct ion_of_heap *compatible)
> 
> CHECK: Alignment should match open parenthesis
> +	heaps = devm_kzalloc(&pdev->dev,
> +				sizeof(struct
> ion_platform_heap)*num_heaps,

Why is your changelog text line-wrapped?

> 
> CHECK: spaces preferred around that '*' (ctx:VxV)
> +				sizeof(struct
> ion_platform_heap)*num_heaps,

Same here.

And don't mix different types of whitespace cleanup in the same patch
please.

thanks,

greg k-h