From: Gustavo Padovan <gustavo@padovan.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/2] drm/exynos: fix pending update handling
Date: Fri, 23 Sep 2016 15:28:02 +0300 [thread overview]
Message-ID: <20160923122802.GB30511@joana> (raw)
In-Reply-To: <1474618524-8916-3-git-send-email-a.hajda@samsung.com>
2016-09-23 Andrzej Hajda <a.hajda@samsung.com>:
> Exynos DRM devices update their registers at vblank time. Exynos-DRM uses
> custom mechanism to wait for vblank. This mechanism is error prone -
> variables are not updated atomically. As a result in certain circumstances
> user space can try to free buffers which are still in use by hardware,
> in such cases IOMMU can throw OOPS.
> The patch instead of fixing the mechanism replaces it with drm core helper.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 16 +-----------
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 44 +-------------------------------
> drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 --
> 3 files changed, 2 insertions(+), 60 deletions(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-09-23 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160923081538eucas1p16f72b58a8c885c07e8188fd33dfafa8c@eucas1p1.samsung.com>
2016-09-23 8:15 ` [PATCH 0/2] Use drm-core helpers to wait for updates Andrzej Hajda
[not found] ` <CGME20160923081541eucas1p277bce738f62966250216ae1da9accc81@eucas1p2.samsung.com>
2016-09-23 8:15 ` [PATCH 1/2] drm/exynos/vidi: use timer for vblanks instead of sleeping worker Andrzej Hajda
2016-09-23 12:27 ` Gustavo Padovan
[not found] ` <CGME20160923081544eucas1p1a734de81448b36af65196f982bee5e27@eucas1p1.samsung.com>
2016-09-23 8:15 ` [PATCH 2/2] drm/exynos: fix pending update handling Andrzej Hajda
2016-09-23 12:28 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923122802.GB30511@joana \
--to=gustavo@padovan.org \
--cc=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.